Extend cisco_ios set_boot_options method (#311)

* Extend cisco_ios set_boot_options method

* Fix test

* refresh poetry.lock

* black, pylint + fix test (setup, teardown) deprecated methods.

pyntc/devices/asa_device.py

@@ -156,7 +156,7 @@ def _get_ipv4_addresses(self, host: str) -> Dict[str, List[IPv4Address]]:
         elif host == "peer":
             command = "failover exec mate show ip address"
 
-        show_ip_address = self.show(command)
+        show_ip_address = self.show(command)  # pylint: disable=possibly-used-before-assignment
         re_ip_addresses = RE_SHOW_IP_ADDRESS.findall(show_ip_address)
 
         results = {
@@ -188,7 +188,7 @@ def _get_ipv6_addresses(self, host: str) -> Dict[str, List[IPv6Address]]:
         elif host == "peer":
             command = "failover exec mate show ipv6 interface"
 
-        show_ipv6_interface = self.show(command)
+        show_ipv6_interface = self.show(command)  # pylint: disable=possibly-used-before-assignment
         show_ipv6_interface_lines: List[str] = show_ipv6_interface.strip().splitlines()
         first_line = show_ipv6_interface_lines.pop(0)
         interface: str = first_line.split()[0]

pyntc/devices/ios_device.py

@@ -1029,6 +1029,11 @@ def set_boot_options(self, image_name, **vendor_specifics):
             ):  # TODO: Update to CommandError when deprecating config_list
                 command = f"boot system switch all {file_system}{image_name}"
                 self.config(["no boot system", command])
+
+            # If boot system is not found in the running config, but it exists in show boot or show bootvar
+            elif self.boot_options["sys"]:
+                command = f"boot system {file_system}/{image_name}"
+                self.config(command)
             else:
                 raise CommandError(
                     command=command,

pyntc/devices/iosxewlc_device.py

@@ -1,4 +1,5 @@
 """Module for using a Cisco IOSXE WLC device over SSH."""
+
 import time
 
 from pyntc import log

pyntc/devices/jnpr_device.py

@@ -1,4 +1,5 @@
 """Module for using a Juniper junOS device."""
+
 import hashlib
 import os
 import re

pyntc/devices/nxos_device.py

@@ -1,4 +1,5 @@
 """Module for using an NXOS device over NX-API."""
+
 import os
 import re
 import time

pyntc/devices/system_features/vlans/base_vlans.py

@@ -1,4 +1,5 @@
 """Base Vlan checks."""
+
 from pyntc.errors import NTCError
 
 from ..base_feature import BaseFeature

pyntc/errors.py

@@ -1,4 +1,5 @@
 """pyntc custom exceptions."""
+
 import warnings
 
 

pyntc/log.py

@@ -1,4 +1,5 @@
 """Logging utilities for Pyntc."""
+
 import os
 import logging
 

pyntc/utils/__init__.py

@@ -1,4 +1,5 @@
 """PyNTC Utilities."""
+
 from .templates import get_structured_data
 from .converters import convert_dict_by_key, convert_list_by_key, recursive_key_lookup
 

pyntc/utils/templates/__init__.py

@@ -1,4 +1,5 @@
 """Module to use NTC_TEMPLATES."""
+
 import os
 import textfsm
 

tasks.py

@@ -1,4 +1,5 @@
 """Tasks for use with Invoke."""
+
 import os
 import sys
 from distutils.util import strtobool

tests/unit/test_devices/test_asa_device.py

@@ -39,7 +39,7 @@
 
 
 class TestASADevice:
-    def setup(self, api):
+    def setup_method(self, api):
         with mock.patch("pyntc.devices.asa_device.ConnectHandler") as api:
             if not getattr(self, "device", None):
                 self.device = ASADevice("host", "user", "password")
@@ -60,7 +60,7 @@ def setup(self, api):
             self.device.native = api
             self.count_setup += 1
 
-    def teardown(self):
+    def teardown_method(self):
         # Reset the mock so we don't have transient test effects
         self.device.native.reset_mock()
         self.count_teardown += 1

tests/unit/test_devices/test_f5_device.py

@@ -27,7 +27,7 @@ def __init__(self, fullPath, version, build):
 
 
 class TestF5Device:
-    def setup(self):
+    def setup_method(self):
         with mock.patch("pyntc.devices.f5_device.ManagementRoot") as big_ip:
             self.device = F5Device("host", "user", "password")
             self.device.api_handler = big_ip
@@ -40,7 +40,7 @@ def setup(self):
 
             self.count_setup += 1
 
-    def teardown(self):
+    def teardown_method(self):
         self.device.api_handler.reset_mock()
         self.count_teardown += 1
 

tests/unit/test_devices/test_ios_device.py

@@ -898,7 +898,7 @@ def test_set_boot_options_pass_with_switch_all(mock_save, mock_boot_options, moc
 
 @mock.patch.object(IOSDevice, "_get_file_system")
 @mock.patch.object(IOSDevice, "config")
-@mock.patch.object(IOSDevice, "boot_options", new_callable=mock.PropertyMock)
+@mock.patch.object(IOSDevice, "boot_options", new_callable=lambda: {"sys": None})
 @mock.patch.object(IOSDevice, "save")
 def test_set_boot_options_raise_commanderror(mock_save, mock_boot_options, mock_config, mock_file_system, ios_show):
     device = ios_show(["dir_flash:.txt", "boot flash:c3560-advipservicesk9-mz.122-44.SE.bin"])