Adding support for Cisco ASA banner when nested underneath a parent config #590
Conversation
…white space. I added that support to both the BaseSpaceConfigParser.banner_start list and to CiscoConfigParser.regex_banner attribute
huacchob
requested review from
itdependsnetworks,
jeffkala,
qduk and
abates
as code owners
|
hey, can you provide test cases for this? |
|
Yes, I can add them |
|
Would this test be enough? |
|
Would you mind just using the existing folder structure? Should just be here: https://github.com/networktocode/netutils/tree/3c1f8de1a8da7d0cc86b6e5cdc7e79dd49d55369/tests/unit/mock/config/parser/base/cisco_asa |
| @@ -53,7 +53,7 @@ class BaseSpaceConfigParser(BaseConfigParser): | |||
| # pylint: disable=abstract-method | |||
|
|
|||
| comment_chars = ["!"] | |||
| banner_start = ["banner", "vacant-message"] | |||
| banner_start = ["banner", "vacant-message", " banner", " banner"] | |||
There was a problem hiding this comment.
I don't understand this, why are we adding banner_start multiple times?
There was a problem hiding this comment.
The first one has has 1 white space and the second one has two.
There was a problem hiding this comment.
I would not think this is how we want to do this then. I would think we would understand the parent / child relationship would be how we determine it.
There was a problem hiding this comment.
Check in with @jmcgill298
There was a problem hiding this comment.
ya, that banner is a child of the group-policy, so it should be captured there. I guess for this case the banner is not multiline?
There was a problem hiding this comment.
The banner is a bit odd. It seems that each line of the banner begins with "banner value". Yes, it is a child config of group-policy
Banner for Cisco ASA could be a child config, and would start with a white space. I added that support to both the BaseSpaceConfigParser.banner_start list and to CiscoConfigParser.regex_banner attribute