-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Container::getValues() do not respects validation scope at all situations #287
Open
norbe
wants to merge
23
commits into
nette:master
Choose a base branch
from
norbe:kh-getvalues-fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: martin.sedlacek <[email protected]>
@dg I see you are actually doing on some changes at validation scope. Is it relevant to this issue? |
dg
force-pushed
the
master
branch
6 times, most recently
from
May 4, 2022 11:46
6137079
to
bef402d
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
April 1, 2024 01:05
49c38f3
to
c6f98c1
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
May 2, 2024 10:56
337f707
to
2146e59
Compare
dg
force-pushed
the
master
branch
6 times, most recently
from
May 12, 2024 13:07
94f43f0
to
fe374c5
Compare
dg
force-pushed
the
master
branch
7 times, most recently
from
August 8, 2024 14:36
cb844f0
to
1d8a434
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
October 22, 2024 18:43
479185b
to
8da5796
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version: 3.1.6
Bug Description
Call $container->getValues() returns emtpy values if $container or his parent is in submit validation scope. See new test case