test: fix code

netlify · Nov 25, 2024 · 98ea076 · 98ea076
1 parent 53ee812
commit 98ea076
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/utils/framework-server.ts b/src/utils/framework-server.ts
@@ -30,10 +30,8 @@ export const startFrameworkServer = async function ({
     if (settings.command) {
       runCommand(settings.command, { env: settings.env, cwd })
     }
-    await startStaticServer({ settings })
-    // const { family } = await startStaticServer({ settings })
-    return {}
-    // return { ipVersion: family === 'IPv6' ? 6 : 4 }
+    const { family } = await startStaticServer({ settings })
+    return { ipVersion: family === 'IPv6' ? 6 : 4 }
   }
 
   log(`${NETLIFYDEVLOG} Starting Netlify Dev with ${settings.framework || 'custom config'}`)

diff --git a/tests/integration/commands/dev/dev.test.ts b/tests/integration/commands/dev/dev.test.ts
@@ -682,7 +682,9 @@ describe.concurrent('command/dev', () => {
             async (server) => {
               const output = server.outputBuffer.map((buff) => buff.toString()).join('\n')
               t.expect(output).toContain('Server now ready')
-              t.expect(server.errorBuffer).toHaveLength(0)
+              // With node 23 we might be getting some warnings, but no errors
+              const errorOutput = server.errorBuffer.map((buff) => buff.toString()).join('\n')
+              t.expect(errorOutput).not.toContain('Error')
             },
           )
         })