Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): Add trace attribute to track failing builds from Netlify maintained extensions/plugins #5914

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

YujohnNattrass
Copy link
Contributor

@YujohnNattrass YujohnNattrass commented Nov 21, 2024

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes #<replace_with_issue_number>

We would like to add monitoring for builds that fail due to Netlify-maintained extensions/plugins.

Here is an example of the monitor. I tested it using a custom extension designed to intentionally fail a deploy during the build process.
Screenshot 2024-11-22 at 1 53 29 PM


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@YujohnNattrass YujohnNattrass changed the title feat(build): track netlify owned extensions feat(build): track when Netlify maintained extensions fail builds Nov 22, 2024
@YujohnNattrass YujohnNattrass marked this pull request as ready for review November 22, 2024 22:06
@YujohnNattrass YujohnNattrass changed the title feat(build): track when Netlify maintained extensions fail builds feat(build): Add trace attribute to track failing builds from Netlify maintained extensions/plugins Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant