feat: support custom URLs to be added to the Sitemap #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support to define custom URLs to be used when generating the Sitemap.
I came across this useful plugin, but it doesn't work for Single Page Applications (SPA.) I thought it would be great to support adding custom URLs to the Sitemap via the plugin.
I think these changes will partly solve #8. Though these changes don't crawl the page, nor try to guess the routes used for the SPA, I think the solution is useful for developers looking for a simple way of adding a few URLs to their sitemap.
I'll put the PR in draft to begin with, because I want to get your opinions of my suggestion. I'm also not sure about what
lastmodfileis used for, so I just omitted it when generating the customURLs.