Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NAE- 1940] Update to new Angular #235

Merged
merged 20 commits into from
Jul 12, 2024
Merged

[NAE- 1940] Update to new Angular #235

merged 20 commits into from
Jul 12, 2024

Conversation

Kovy95
Copy link
Contributor

@Kovy95 Kovy95 commented Feb 8, 2024

Description

kedze 6.5.0 bola vytvorena zo 6.4.0 (aj ked som ziadal NAE-1906), je takmer nemozne skontrolovat tento PR

Implements NAE-1940

Dependencies

"@angular-material-components/datetime-picker": "~16.0.0",
"@angular-material-components/moment-adapter": "~16.0.0",
"@angular/animations": "^17.1.0",
"@angular/cdk": "^17.1.0",
"@angular/common": "^17.1.0",
"@angular/compiler": "^17.1.0",
"@angular/core": "^17.1.0",
"@angular/forms": "^17.1.0",
"@angular/material": "^17.1.0",
"@angular/material-moment-adapter": "^17.1.0",
"@angular/platform-browser": "^17.1.0",
"@angular/platform-browser-dynamic": "^17.1.0",
"@angular/router": "^17.1.0",
"@covalent/markdown": "~8.0.0",
"@ngbracket/ngx-layout": "^17.0.1",
"@ngx-translate/core": "~15.0.0",
"@ngx-translate/http-loader": "~8.0.0",
"@schematics/angular": "^17.1.0",
"angular-resizable-element": "~7.0.0",
"angular-resize-event": "~3.2.0",
"angular2-hotkeys": "~16.0.0",
"@angular-devkit/build-angular": "^17.1.0",
"@angular-devkit/schematics-cli": "^17.1.0",
"@angular-eslint/builder": "~17.1.0",
"@angular-eslint/eslint-plugin": "~17.1.0",
"@angular-eslint/eslint-plugin-template": "~17.1.0",
"@angular-eslint/schematics": "~17.1.0",
"@angular-eslint/template-parser": "~17.1.0",
"@angular/cli": "^17.1.0",
"@angular/compiler-cli": "^17.1.0",
"@angular/language-service": "^17.1.0",
"@compodoc/compodoc": "1.1.23",
"@types/jasmine": "~3.10.0",
"@types/jasminewd2": "~2.0.10",
"@typescript-eslint/eslint-plugin": "~6.21.0",
"@typescript-eslint/parser": "~6.21.0",
"jasmine-core": "~5.1.0",
"jasmine-spec-reporter": "~7.0.0",
"json-server": "~0.17.4",
"karma": "~6.4.2",
"karma-webpack": "^5.0.1",
"karma-chrome-launcher": "~3.2.0",
"karma-coverage-istanbul-reporter": "~3.0.0",
"karma-firefox-launcher": "~2.1.0",
"karma-jasmine": "~5.1.0",
"karma-jasmine-html-reporter": "~2.1.0",
"ng-packagr": "^17.1.0",
"puppeteer": "~22.0.0",
"typescript": "~5.2.0",
"typescript-json-schema": "~0.60.0",

Third party dependencies

ngbracket/ngx-layout - fork of Angular Flex Layout, which was discontinued

Blocking Pull requests

There are no dependencies on other PR

How Has Been This Tested?

manually

Test Configuration

<Please describe configuration for tests to run if applicable, like program parameters, host OS, VM configuration etc. You can use >

Name Tested on
OS Linux Mint 20
Runtime NodeJS 20.11.0
Dependency Manager NPM 10.2.4
Framework version Angular 17.1.0
Run parameters
Other configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes have been checked, personally or remotely, with @...
  • I have commented my code, particularly in hard-to-understand areas
  • I have resolved all conflicts with the target branch of the PR
  • I have updated and synced my code with the target branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes:
    • Lint test
    • Unit tests
    • Integration tests
  • I have checked my contribution with code analysis tools:
  • I have made corresponding changes to the documentation:
    • Developer documentation
    • User Guides
    • Migration Guides

 - commit new versions
 - commit angular 14 version
 - commit angular 15 version
 - fix some of scss
 - commit angular 16 version
 - commit angular 17 version
 - fix some scss files
# Conflicts:
#	package.json
#	projects/netgrif-components-core/package.json
#	projects/netgrif-components/package.json
@Kovy95 Kovy95 added improvement New feature or request breaking change Fix or feature that would cause existing functionality doesn't work as expected new dependency Extra Large upgrade labels Feb 8, 2024
@Kovy95 Kovy95 self-assigned this Feb 8, 2024

This PR has 22259 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +13579 -8680
Percentile : 100%

Total files changed: 1432

Change summary by file extension:
.gitignore : +1 -1
.md : +97 -19
.json : +172 -138
.html : +3449 -4435
.js : +126 -112
.svg : +337 -293
.ts : +7898 -3201
.scss : +1490 -474
.txt : +2 -2
.template : +1 -1
projects/nae-example-app/browserslist : +6 -4

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 1360 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +571 -789
Percentile : 100%

Total files changed: 266

Change summary by file extension:
.json : +126 -125
.ts : +174 -439
.scss : +213 -181
.md : +2 -2
.js : +14 -0
.txt : +2 -2
.html : +34 -36
projects/nae-example-app/browserslist : +6 -4

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

- fix merge problems with mat-chip in user-list-default-field.component.html
- export interfaces from data-fields public-api.ts
- add missing LoggerService argument in breadcrumbs.component.ts

This PR has 1375 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +580 -795
Percentile : 100%

Total files changed: 268

Change summary by file extension:
.json : +126 -125
.ts : +181 -443
.scss : +213 -181
.md : +2 -2
.js : +14 -0
.txt : +2 -2
.html : +36 -38
projects/nae-example-app/browserslist : +6 -4

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

 - add new version of rxjs for compatibility with builder
 - fix some issues

This PR has 1401 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +593 -808
Percentile : 100%

Total files changed: 274

Change summary by file extension:
.json : +127 -126
.ts : +193 -455
.scss : +213 -181
.md : +2 -2
.js : +14 -0
.txt : +2 -2
.html : +36 -38
projects/nae-example-app/browserslist : +6 -4

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

# Conflicts:
#	package.json
#	projects/netgrif-components-core/package.json
#	projects/netgrif-components-core/src/lib/data-fields/file-field/abstract-file-field.component.ts
#	projects/netgrif-components/nae-theme.scss
#	projects/netgrif-components/package.json
#	projects/netgrif-components/src/lib/data-fields/button-field/button-default-field/button-default-field.component.html
#	projects/netgrif-components/src/lib/data-fields/button-field/button-default-field/button-default-field.component.scss
#	projects/netgrif-components/src/lib/data-fields/data-field.theme.scss
#	projects/netgrif-components/src/lib/data-fields/user-list-field/user-list-default-field/user-list-default-field.component.html
 - fixes of css in the whole application
 - fixes of user field
 - fixes of multichoice autocomplete
@tuplle tuplle changed the base branch from release/6.5.0 to release/7.0.0 July 1, 2024 09:29
Copy link

sonarcloud bot commented Jul 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
22.6% Coverage on New Code (required ≥ 50%)
3.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@tuplle tuplle merged commit fe552ef into release/7.0.0 Jul 12, 2024
6 of 8 checks passed
@tuplle tuplle deleted the NAE-1940 branch July 12, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Fix or feature that would cause existing functionality doesn't work as expected Extra Large improvement New feature or request new dependency upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants