-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NAE- 1940] Update to new Angular #235
Conversation
- commit new versions
- commit angular 14 version
- commit angular 15 version - fix some of scss
- commit angular 16 version
- commit angular 17 version - fix some scss files
# Conflicts: # package.json # projects/netgrif-components-core/package.json # projects/netgrif-components/package.json
- fix tests
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
- fix merge problems with mat-chip in user-list-default-field.component.html - export interfaces from data-fields public-api.ts - add missing LoggerService argument in breadcrumbs.component.ts
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
- add new version of rxjs for compatibility with builder - fix some issues
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
# Conflicts: # package.json # projects/netgrif-components-core/package.json # projects/netgrif-components-core/src/lib/data-fields/file-field/abstract-file-field.component.ts # projects/netgrif-components/nae-theme.scss # projects/netgrif-components/package.json # projects/netgrif-components/src/lib/data-fields/button-field/button-default-field/button-default-field.component.html # projects/netgrif-components/src/lib/data-fields/button-field/button-default-field/button-default-field.component.scss # projects/netgrif-components/src/lib/data-fields/data-field.theme.scss # projects/netgrif-components/src/lib/data-fields/user-list-field/user-list-default-field/user-list-default-field.component.html
- fix after merge
- fixes of css in the whole application
- fixes of user field
- fixes of multichoice autocomplete
- fix tests
Quality Gate failedFailed conditions |
Description
kedze 6.5.0 bola vytvorena zo 6.4.0 (aj ked som ziadal NAE-1906), je takmer nemozne skontrolovat tento PR
Implements NAE-1940
Dependencies
"@angular-material-components/datetime-picker": "~16.0.0",
"@angular-material-components/moment-adapter": "~16.0.0",
"@angular/animations": "^17.1.0",
"@angular/cdk": "^17.1.0",
"@angular/common": "^17.1.0",
"@angular/compiler": "^17.1.0",
"@angular/core": "^17.1.0",
"@angular/forms": "^17.1.0",
"@angular/material": "^17.1.0",
"@angular/material-moment-adapter": "^17.1.0",
"@angular/platform-browser": "^17.1.0",
"@angular/platform-browser-dynamic": "^17.1.0",
"@angular/router": "^17.1.0",
"@covalent/markdown": "~8.0.0",
"@ngbracket/ngx-layout": "^17.0.1",
"@ngx-translate/core": "~15.0.0",
"@ngx-translate/http-loader": "~8.0.0",
"@schematics/angular": "^17.1.0",
"angular-resizable-element": "~7.0.0",
"angular-resize-event": "~3.2.0",
"angular2-hotkeys": "~16.0.0",
"@angular-devkit/build-angular": "^17.1.0",
"@angular-devkit/schematics-cli": "^17.1.0",
"@angular-eslint/builder": "~17.1.0",
"@angular-eslint/eslint-plugin": "~17.1.0",
"@angular-eslint/eslint-plugin-template": "~17.1.0",
"@angular-eslint/schematics": "~17.1.0",
"@angular-eslint/template-parser": "~17.1.0",
"@angular/cli": "^17.1.0",
"@angular/compiler-cli": "^17.1.0",
"@angular/language-service": "^17.1.0",
"@compodoc/compodoc": "1.1.23",
"@types/jasmine": "~3.10.0",
"@types/jasminewd2": "~2.0.10",
"@typescript-eslint/eslint-plugin": "~6.21.0",
"@typescript-eslint/parser": "~6.21.0",
"jasmine-core": "~5.1.0",
"jasmine-spec-reporter": "~7.0.0",
"json-server": "~0.17.4",
"karma": "~6.4.2",
"karma-webpack": "^5.0.1",
"karma-chrome-launcher": "~3.2.0",
"karma-coverage-istanbul-reporter": "~3.0.0",
"karma-firefox-launcher": "~2.1.0",
"karma-jasmine": "~5.1.0",
"karma-jasmine-html-reporter": "~2.1.0",
"ng-packagr": "^17.1.0",
"puppeteer": "~22.0.0",
"typescript": "~5.2.0",
"typescript-json-schema": "~0.60.0",
Third party dependencies
ngbracket/ngx-layout - fork of Angular Flex Layout, which was discontinued
Blocking Pull requests
There are no dependencies on other PR
How Has Been This Tested?
manually
Test Configuration
<Please describe configuration for tests to run if applicable, like program parameters, host OS, VM configuration etc. You can use >
Checklist: