-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NAE-1617] Refactor authority #169
base: release/6.4.0
Are you sure you want to change the base?
Conversation
- timo comments
- add components and services for user impersonation - extend UserResource, User and UserTransformer classes - add demo component to example app
- fix example app component
- override permission with impersonated user
- improve impersonation stream
- rename and move component
- implement impersonation by config (alternative to impersonation directly by user id)
- add buttons for impersonation into drawer components - add localization (german todo)
- improve visual (bigger menu for impersonation) - change impersonation case view headers
- clean up
- fix test
- fix for lint
- fix test
- code smell - add tests for impersonation.service
- fix test
- add de locale for impersonation
- add de locale for impersonation
- update according to PR comments
- improvements based on PR comments
# Conflicts: # package.json # projects/netgrif-components-core/package.json # projects/netgrif-components/package.json
- improvements based on machacjozef PR comments
- fix test after merge
- changes based on PR comments
[NAE-1678] User impersonation
[NAE-1797] I18N field at asynchronous rendering
[NAE-1790] Validation message on the date field is not displaying correctly
[NAE-1759] Update documentation of public views, PDF generator and user list
# Conflicts: # package.json # projects/netgrif-components-core/package.json # projects/netgrif-components/package.json
- implemented required changes for frontend too
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Kudos, SonarCloud Quality Gate passed! |
Description
Implemented required changes for authority refactor.
Implements NAE-1617
Dependencies
No new dependencies were introduced.
Third party dependencies
No new dependencies were introduced.
Blocking Pull requests
There are no dependencies on other PR.
How Has Been This Tested?
This was tested manually and with unit tests.
Test Configuration
Checklist: