NGSTACK-883 add missing icons and replace base64 with svg icons #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are changes here committed that must be removed before making a PR to media-site!
…tor js components
…e px with rem, reorder css
…alue, change px to rem
…yling NGSTACK-876 add scss files for notification module
Ngstack 873 bookmarks styling
NGSTACK-853 remove unecessary changes NGSTACK-853 add empty line at the end of the file
NGSTACK-853 impersonation module
emodric
reviewed
May 8, 2024
| @@ -74,6 +74,7 @@ | |||
| "@netgen/javascript-cookie-control": "^0.0.8", | |||
| "@popperjs/core": "^2.11.6", | |||
| "bootstrap": "^5.3.3", | |||
| "flatpickr": "^4.6.13", | |||
There was a problem hiding this comment.
Yeah...I don't know what happened, but I had to add it again
emodric
approved these changes
May 9, 2024
|
@Ljudevit Please review! |
|
@TTrakostanec Before merging, the icons should go to |
emodric
force-pushed
the
netgen-org-site
branch
2 times, most recently
from
392e5f2
to
8cc0aaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason it didn't add flatpickr (which was added for this task https://netgen.atlassian.net/browse/NGSTACK-873) so I had to add it again