CED-1124 NGSTACK-831 edit infocollection #89
Conversation
…getLegacyValue method
ludwig031
force-pushed
the
CED-1124-edit-infocollection
branch
from
ef6f4b3
to
39638ea
Compare
|
Rebased branch to 3.x to get new changes |
lib/Core/Persistence/FieldHandler/Custom/CountryFieldHandler.php
Outdated
Show resolved
Hide resolved
| use Symfony\Component\Form\FormBuilderInterface; | ||
| use Symfony\Component\Validator\Constraints; | ||
|
|
||
| final class UserUpdateType extends UserType |
There was a problem hiding this comment.
We won't need this for info collection, please remove it.
| use Symfony\Component\Form\FormBuilderInterface; | ||
| use Symfony\Component\Validator\Constraints; | ||
|
|
||
| final class UserCreateType extends UserType |
There was a problem hiding this comment.
We won't need this for info collection, please remove it.
bundle/Form/DataWrapper.php
Outdated
| * | ||
| * @var mixed | ||
| */ | ||
| public $payload; |
There was a problem hiding this comment.
Missing type hint (below as well).
bundle/Form/DataWrapper.php
Outdated
| public $definition; | ||
|
|
||
| /** | ||
| * The target struct that applies to. E.g. Content, User, Section object and so on. |
There was a problem hiding this comment.
Adapt descriptions for info collection context.
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Netgen\Bundle\InformationCollectionBundle\Form\Type; |
There was a problem hiding this comment.
Since we have this namespace how, move other form types here.
| netgen_information_collection.form.fieldtype_handler.ezimage: | ||
| class: Netgen\Bundle\InformationCollectionBundle\Form\FieldTypeHandler\Image | ||
| tags: | ||
| - { name: netgen.ibexa_forms.form.fieldtype_handler, alias: ezimage } |
There was a problem hiding this comment.
Adapt tag name for this bundle.
| * @throws \OutOfBoundsException | ||
| * @throws \RuntimeException When type is not a FieldTypeHandlerInterface instance nor a callable factory | ||
| */ | ||
| public function get(string $identifier): FieldTypeHandlerInterface|\Netgen\Bundle\IbexaFormsBundle\Form\FieldTypeHandlerInterface |
There was a problem hiding this comment.
Second return type hint was for Birthday field type? We should copy it's handler here once the tag names are updated, so the handlers are not in conflict.
| /** | ||
| * Register a $service for FieldType $identifier. | ||
| * | ||
| * @param \Netgen\Bundle\InformationCollectionBundle\Form\FieldTypeHandlerInterface|callable $handler |
There was a problem hiding this comment.
I think we can remove callable, this was initially implemented for quite old SF version.
| * | ||
| * @param \Netgen\Bundle\InformationCollectionBundle\Form\FieldTypeHandlerInterface|callable $handler | ||
| */ | ||
| public function register(string $identifier, $handler): void |
There was a problem hiding this comment.
Typehit FieldTypeHandlerInterface.
| } | ||
| if (!$this->map[$identifier] instanceof FieldTypeHandlerInterface && !$this->map[$identifier] instanceof \Netgen\Bundle\IbexaFormsBundle\Form\FieldTypeHandlerInterface) { | ||
|
|
||
| if (!is_callable($this->map[$identifier])) { |
…FieldTypeHandlerRegistry.php
…dTypeHandlerInterface
iherak
changed the title
Implemented editing the info collection.