Check if string length constraint exists before using

netgen · Aug 19, 2015 · 57270c9 · 57270c9
1 parent 707a150
commit 57270c9
Showing 1 changed file with 18 additions and 14 deletions.
diff --git a/Form/FieldTypeHandler/TextLine.php b/Form/FieldTypeHandler/TextLine.php
@@ -38,23 +38,27 @@ protected function buildFieldForm(
     {
         $options = $this->getDefaultFieldOptions( $fieldDefinition, $languageCode, $content );
 
-        $minStringLength = $fieldDefinition->validatorConfiguration["StringLengthValidator"]["minStringLength"];
-        $maxStringLength = $fieldDefinition->validatorConfiguration["StringLengthValidator"]["maxStringLength"];
-        $lengthConstraints = array();
-
-        if ( $minStringLength !== false )
+        if ( !empty( $fieldDefinition->validatorConfiguration["StringLengthValidator"] ) )
         {
-            $lengthConstraints["min"] = $minStringLength;
-        }
+            $lengthConstraints = array();
 
-        if ( $maxStringLength !== false )
-        {
-            $lengthConstraints["max"] = $maxStringLength;
-        }
+            $minStringLength = $fieldDefinition->validatorConfiguration["StringLengthValidator"]["minStringLength"];
+            $maxStringLength = $fieldDefinition->validatorConfiguration["StringLengthValidator"]["maxStringLength"];
 
-        if ( !empty( $lengthConstraints ) )
-        {
-            $options["constraints"][] = new Constraints\Length( $lengthConstraints );
+            if ( $minStringLength !== false )
+            {
+                $lengthConstraints["min"] = $minStringLength;
+            }
+
+            if ( $maxStringLength !== false )
+            {
+                $lengthConstraints["max"] = $maxStringLength;
+            }
+
+            if ( !empty( $lengthConstraints ) )
+            {
+                $options["constraints"][] = new Constraints\Length( $lengthConstraints );
+            }
         }
 
         $formBuilder->add( $fieldDefinition->identifier, "text", $options );