Add extra logs for account not found, peer login and getAccount (#2053)

netbirdio · May 27, 2024 · f176807 · f176807
1 parent d4c47ea
commit f176807
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/management/server/account.go b/management/server/account.go
@@ -1768,6 +1768,8 @@ func (am *DefaultAccountManager) GetAccountFromToken(claims jwtclaims.Authorizat
 //
 // Existing user + Existing account + Existing domain reclassified Domain as private -> Nothing changes (index domain)
 func (am *DefaultAccountManager) getAccountWithAuthorizationClaims(claims jwtclaims.AuthorizationClaims) (*Account, error) {
+ log.Tracef("getting account with authorization claims. User ID: \"%s\", Account ID: \"%s\", Domain: \"%s\", Domain Category: \"%s\"",
+ claims.UserId, claims.AccountId, claims.Domain, claims.DomainCategory)
  if claims.UserId == "" {
  return nil, fmt.Errorf("user ID is empty")
  }

diff --git a/management/server/grpcserver.go b/management/server/grpcserver.go
@@ -368,7 +368,7 @@ func (s *GRPCServer) Login(ctx context.Context, req *proto.EncryptedMessage) (*p
  })
 
  if err != nil {
- log.Warnf("failed logging in peer %s", peerKey)
+ log.Warnf("failed logging in peer %s: %s", peerKey, err)
  return nil, mapError(err)
  }
 

diff --git a/management/server/sql_store.go b/management/server/sql_store.go
@@ -390,7 +390,7 @@ func (s *SqlStore) GetAccount(accountID string) (*Account, error) {
  Preload(clause.Associations).
  First(&account, "id = ?", accountID)
  if result.Error != nil {
- log.Errorf("error when getting account from the store: %s", result.Error)
+ log.Errorf("error when getting account %s from the store: %s", accountID, result.Error)
  if errors.Is(result.Error, gorm.ErrRecordNotFound) {
  return nil, status.Errorf(status.NotFound, "account not found")
  }