Skip to content

[relay] Improve relay messages #6313

[relay] Improve relay messages

[relay] Improve relay messages #6313

Triggered via pull request September 10, 2024 22:19
@pappzpappz
synchronize #2574
hmacv2
Status Failure
Total duration 9m 59s
Artifacts

golangci-lint.yml

on: pull_request
codespell
9s
codespell
Matrix: lint
Fit to window
Zoom out
Zoom in

Annotations

21 errors and 4 warnings
lint (ubuntu-latest): relay/server/relay.go#L175
SA1019: messages.MsgTypeHello is deprecated: Use MsgTypeAuth instead. (staticcheck)
lint (ubuntu-latest): relay/server/relay.go#L195
SA1019: messages.UnmarshalHelloMsg is deprecated: Use UnmarshalAuthMsg instead. UnmarshalHelloMsg extracts peerID and the additional data from the hello message. The Additional data is used to authenticate the client with the server. (staticcheck)
lint (ubuntu-latest): relay/server/relay.go#L208
SA1019: r.validator.ValidateHelloMsgType is deprecated: Use Validate instead. (staticcheck)
lint (ubuntu-latest): relay/server/relay.go#L218
SA1019: messages.MarshalHelloResponse is deprecated: Use MarshalAuthResponse instead. MarshalHelloResponse creates a response message to the hello message. In case of success connection the server response with a Hello Response message. This message contains the server's instance URL. This URL will be used by choose the common Relay server in case if the peers are in different Relay servers. (staticcheck)
lint (ubuntu-latest): relay/server/relay.go#L16
SA1019: "github.com/netbirdio/netbird/relay/messages/address" is deprecated: This package is deprecated and will be removed in a future release. (staticcheck)
lint (ubuntu-latest): relay/server/relay.go#L17
SA1019: "github.com/netbirdio/netbird/relay/messages/auth" is deprecated: This package is deprecated and will be removed in a future release. (staticcheck)
lint (ubuntu-latest)
issues found
lint (macos-latest): relay/server/relay.go#L175
SA1019: messages.MsgTypeHello is deprecated: Use MsgTypeAuth instead. (staticcheck)
lint (macos-latest): relay/server/relay.go#L195
SA1019: messages.UnmarshalHelloMsg is deprecated: Use UnmarshalAuthMsg instead. UnmarshalHelloMsg extracts peerID and the additional data from the hello message. The Additional data is used to authenticate the client with the server. (staticcheck)
lint (macos-latest): relay/server/relay.go#L208
SA1019: r.validator.ValidateHelloMsgType is deprecated: Use Validate instead. (staticcheck)
lint (macos-latest): relay/server/relay.go#L218
SA1019: messages.MarshalHelloResponse is deprecated: Use MarshalAuthResponse instead. MarshalHelloResponse creates a response message to the hello message. In case of success connection the server response with a Hello Response message. This message contains the server's instance URL. This URL will be used by choose the common Relay server in case if the peers are in different Relay servers. (staticcheck)
lint (macos-latest): relay/server/relay.go#L16
SA1019: "github.com/netbirdio/netbird/relay/messages/address" is deprecated: This package is deprecated and will be removed in a future release. (staticcheck)
lint (macos-latest): relay/server/relay.go#L17
SA1019: "github.com/netbirdio/netbird/relay/messages/auth" is deprecated: This package is deprecated and will be removed in a future release. (staticcheck)
lint (macos-latest)
issues found
lint (windows-latest): relay/server/relay.go#L175
SA1019: messages.MsgTypeHello is deprecated: Use MsgTypeAuth instead. (staticcheck)
lint (windows-latest): relay/server/relay.go#L195
SA1019: messages.UnmarshalHelloMsg is deprecated: Use UnmarshalAuthMsg instead. UnmarshalHelloMsg extracts peerID and the additional data from the hello message. The Additional data is used to authenticate the client with the server. (staticcheck)
lint (windows-latest): relay/server/relay.go#L208
SA1019: r.validator.ValidateHelloMsgType is deprecated: Use Validate instead. (staticcheck)
lint (windows-latest): relay/server/relay.go#L218
SA1019: messages.MarshalHelloResponse is deprecated: Use MarshalAuthResponse instead. MarshalHelloResponse creates a response message to the hello message. In case of success connection the server response with a Hello Response message. This message contains the server's instance URL. This URL will be used by choose the common Relay server in case if the peers are in different Relay servers. (staticcheck)
lint (windows-latest): relay/server/relay.go#L16
SA1019: "github.com/netbirdio/netbird/relay/messages/address" is deprecated: This package is deprecated and will be removed in a future release. (staticcheck)
lint (windows-latest): relay/server/relay.go#L17
SA1019: "github.com/netbirdio/netbird/relay/messages/auth" is deprecated: This package is deprecated and will be removed in a future release. (staticcheck)
lint (windows-latest)
issues found
codespell
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
lint (ubuntu-latest)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v4, golangci/golangci-lint-action@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
lint (macos-latest)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v4, golangci/golangci-lint-action@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
lint (windows-latest)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v4, golangci/golangci-lint-action@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/