improve activtiy event docs #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braginini
reviewed
Aug 21, 2024
braginini
reviewed
Aug 21, 2024
braginini
reviewed
Aug 21, 2024
| The current version of NetBird tracks network changes that occur in the Management server. E.g., changes related to the list of peers, groups, system settings, setup keys, access control, etc. | ||
| The future versions will support connection events that occur in NetBird agents (e.g., peer A connected to peer B). | ||
| </Note> | ||
| The current version of NetBird tracks network changes that occur in the Management server, such as modifications to the list of peers, groups, system settings, setup keys, and access control policies. Future versions will also support connection events that occur in NetBird agents (e.g., peer A connected to peer B). |
There was a problem hiding this comment.
Maybe we should add the whole list as a table?
https://github.com/netbirdio/netbird/blob/5d6dfe59388d43467599603ad4d803f1e0fcd8eb/management/server/activity/codes.go#L144
There was a problem hiding this comment.
yeah good idea, maybe a summed up version
braginini
reviewed
Aug 21, 2024
braginini
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.