-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for GraphQL Federation #802
Add docs for GraphQL Federation #802
Conversation
1d8c767
to
589bb41
Compare
cc @johnbiundo can you review when you have some time? it just got unlocked :) |
ce9533a
to
060468e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a number of small suggestions (style and grammar).
Also, I believe the .html file should not be in the commit (@kamilmysliwiec ?)
Suggestions accepted :) thank you! You're right about not including the |
This need more work or can be merged? |
ping @kamilmysliwiec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some typos.
@jarvisuser90 Thank you! |
Thanks! |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
N/A
Does this PR introduce a breaking change?
Other information
Documents the Federation module from nestjs/graphql#455