Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for GraphQL Federation #802

Merged
merged 7 commits into from
Mar 3, 2020

Conversation

rickdgeerling
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[X] Other... Please describe: Documentation

What is the current behavior?

Issue Number: N/A

What is the new behavior?

N/A

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

Documents the Federation module from nestjs/graphql#455

@kamilmysliwiec
Copy link
Member

cc @johnbiundo can you review when you have some time? it just got unlocked :)

Copy link
Member

@johnbiundo johnbiundo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a number of small suggestions (style and grammar).

Also, I believe the .html file should not be in the commit (@kamilmysliwiec ?)

@rickdgeerling
Copy link
Contributor Author

Suggestions accepted :) thank you!

You're right about not including the .html file. It's ignored by default so I have no idea how it ended up in there.

@gperdomor
Copy link
Contributor

This need more work or can be merged?

@gperdomor
Copy link
Contributor

ping @kamilmysliwiec

Copy link

@jarvisuser90 jarvisuser90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some typos.

content/graphql/federation.md Outdated Show resolved Hide resolved
content/graphql/federation.md Outdated Show resolved Hide resolved
@rickdgeerling
Copy link
Contributor Author

@jarvisuser90 Thank you!

@kamilmysliwiec
Copy link
Member

Thanks!

@kamilmysliwiec kamilmysliwiec merged commit ef9567f into nestjs:master Mar 3, 2020
@rickdgeerling rickdgeerling deleted the feat/federation-docs branch May 2, 2020 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants