-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/rgbpp top holders #2384
base: develop
Are you sure you want to change the base?
Feat/rgbpp top holders #2384
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2384 +/- ##
============================================
- Coverage 67.56% 55.13% -12.43%
============================================
Files 289 375 +86
Lines 7944 10794 +2850
============================================
+ Hits 5367 5951 +584
- Misses 2577 4843 +2266 ☔ View full report in Codecov by Sentry. |
def btc_top_holders(udt) | ||
result = BitcoinAddressMapping. | ||
joins("LEFT OUTER JOIN udt_accounts ON udt_accounts.address_id = bitcoin_address_mappings.ckb_address_id"). | ||
where(udt_accounts: { udt_id: udt.id }). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are accounts with zero balance in this table? If so, append a filter amount > 0 could speed up this query
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are accounts with zero balance in this table? If so, append a filter amount > 0 could speed up this query
Added filter condition: where("udt_accounts.amount > 0")
No description provided.