-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more sophisticated internet connectivity checker #520
base: main
Are you sure you want to change the base?
Conversation
5a859f4
to
e34b05c
Compare
8167006
to
6be5110
Compare
bccd098
to
7a83e52
Compare
@ConnorRigby I made some changes in the Other things that I'm thinking about:
Overall, I think this is looking really good. |
I think passing a function around is fine. I just added the behaviour for easy typing. I think a typespec will also suffice. Should i change it back to the
how about |
The changes in your branch look great to me. |
dcea8ee
to
371f122
Compare
f87b891
to
f38417e
Compare
4027e42
to
5964f92
Compare
Signed-off-by: Connor Rigby <[email protected]>
Signed-off-by: Connor Rigby <[email protected]>
Signed-off-by: Connor Rigby <[email protected]>
Signed-off-by: Connor Rigby <[email protected]>
Signed-off-by: Connor Rigby <[email protected]>
…entation Signed-off-by: Connor Rigby <[email protected]>
Signed-off-by: Connor Rigby <[email protected]>
Signed-off-by: Connor Rigby <[email protected]>
Signed-off-by: Connor Rigby <[email protected]>
Signed-off-by: Connor Rigby <[email protected]>
Signed-off-by: Connor Rigby <[email protected]>
Signed-off-by: Connor Rigby <[email protected]>
Signed-off-by: Connor Rigby <[email protected]>
…ries Signed-off-by: Connor Rigby <[email protected]>
Signed-off-by: Connor Rigby <[email protected]>
Signed-off-by: Connor Rigby <[email protected]>
Signed-off-by: Connor Rigby <[email protected]>
Signed-off-by: Connor Rigby <[email protected]>
Signed-off-by: Connor Rigby <[email protected]>
Signed-off-by: Connor Rigby <[email protected]>
Signed-off-by: Connor Rigby <[email protected]>
…ecks Signed-off-by: Connor Rigby <[email protected]>
Signed-off-by: Connor Rigby <[email protected]>
1fc6e15
to
44804d7
Compare
Signed-off-by: Connor Rigby <[email protected]>
44804d7
to
1ba959f
Compare
This adds the ability to detect sneaky firewalls or anything else that may give false positives on internet connectivity by checking that a valid SSL connection can be made to a list of hosts.