Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid nvcc compilation error on Windows (fixes #54) #55

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

machenmusik
Copy link
Contributor

@machenmusik machenmusik commented Oct 18, 2023

Added define as per facebookresearch/pytorch3d#1614 (comment)
Fixes #54.

@machenmusik machenmusik changed the title Avoid nvcc compilation error (fixes #54) Avoid nvcc compilation error on Windows (fixes #54) Oct 18, 2023
@machenmusik
Copy link
Contributor Author

(I needed this on Windows for nerfstudio-project/nerfstudio#2521 and nerfstudio-project/nerfstudio#2537 )

Copy link
Collaborator

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tancik tancik merged commit d96d59d into nerfstudio-project:main Oct 18, 2023
2 checks passed
maturk pushed a commit that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CUDA build error on Windows
2 participants