Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong torch cat dim when concatenating colors+depths in simple_trainer_2dgs.py #508

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: wrong torch cat dim when concatenating colors+depths in simple_trainer_2dgs.py #508

wants to merge 1 commit into from

Conversation

Crescent-Saturn
Copy link

A minor type in example/simple_trainer_2dgs.py

It was a useless if condition there. I thought you wanted to concatenate colors and depths along different directions based on their shape for better visualization:

  • Vertical if width > height
  • Horizontal else

Thanks for your time!

@Crescent-Saturn
fix: wrong torch cat dim when saving colors+depths
1382209 
A minor type in example/simple_trainer_2dgs.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Crescent-Saturn