Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[8.x] [Security Solution] Fix the feature app list (elastic#191965) (e…
…lastic#194541) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Fix the feature app list (elastic#191965)](elastic#191965) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sergi Massaneda","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-01T10:18:17Z","message":"[Security Solution] Fix the feature app list (elastic#191965)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana-team/issues/1136\r\n\r\nThe Kibana feature definition for Security Solution was missing the\r\ncorrect plugin ID registered in the `app` definition. We were still\r\ndefining the old _\"securitySolution\"_ app ID in the `app` property,\r\ninstead of the new _\"securitySolutionUI\"_ ID.\r\n\r\nThe Security Solution plugin ID change (_\"securitySolution\"_ ->\r\n_\"securitySolutionUI\"_) was done a long time ago, the inconsistency with\r\nthe Security feature definition is causing the _Security_ app to still\r\nbe visible in the global search when the Security feature is disabled:\r\n\r\n- In the role features\r\n<img width=\"737\" alt=\"Security and Cases disabled\"\r\nsrc=\"https://github.com/user-attachments/assets/146b8205-90f7-4218-9f1a-7b55c3bad563\">\r\n\r\n- Or in the space features config\r\n<img width=\"1213\" alt=\"Captura de pantalla 2024-09-03 a les 15 31 09\"\r\nsrc=\"https://github.com/user-attachments/assets/2563675a-d956-4422-a887-d6d95bcad773\">\r\n\r\n\r\nThis is fixed now:\r\n\r\nBefore:\r\n<img width=\"1302\" alt=\"Security app incorrectly enabled\"\r\nsrc=\"https://github.com/user-attachments/assets/8031f054-7cfb-4098-93c2-eac402501887\">\r\n\r\nAfter:\r\n<img width=\"1302\" alt=\"Security app disabled properly\"\r\nsrc=\"https://github.com/user-attachments/assets/a4f38ec2-fb78-4b1b-8c2d-bac58b97ff99\">\r\n\r\n\r\n### Caveat\r\n\r\nAs per this PR changes: https://github.com/elastic/kibana/pull/113573\r\nIn the Kibana features of the role, under the Security catalog, both\r\nSecurity and Cases features need to be `none` for the Security Solution\r\nplugin to be disabled. Otherwise, we must enable the plugin and make the\r\nenabled features available. So, with a role with the following Kibana\r\nfeatures:\r\n\r\n<img width=\"737\" alt=\"Security disabled cases enabled\"\r\nsrc=\"https://github.com/user-attachments/assets/aca8288e-9dd9-49d0-b864-e60273d30759\">\r\n\r\nThe Security app needs to be available and display only Cases available:\r\n\r\n<img width=\"247\" alt=\"navigation with only cases\"\r\nsrc=\"https://github.com/user-attachments/assets/d4866edb-1d1d-4290-a399-76a37536b05c\">\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"e373e443770399d4b0401b02abc39f794a3ec321","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","Team: SecuritySolution","backport:prev-minor","v8.16.0"],"title":"[Security Solution] Fix the feature app list","number":191965,"url":"https://github.com/elastic/kibana/pull/191965","mergeCommit":{"message":"[Security Solution] Fix the feature app list (elastic#191965)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana-team/issues/1136\r\n\r\nThe Kibana feature definition for Security Solution was missing the\r\ncorrect plugin ID registered in the `app` definition. We were still\r\ndefining the old _\"securitySolution\"_ app ID in the `app` property,\r\ninstead of the new _\"securitySolutionUI\"_ ID.\r\n\r\nThe Security Solution plugin ID change (_\"securitySolution\"_ ->\r\n_\"securitySolutionUI\"_) was done a long time ago, the inconsistency with\r\nthe Security feature definition is causing the _Security_ app to still\r\nbe visible in the global search when the Security feature is disabled:\r\n\r\n- In the role features\r\n<img width=\"737\" alt=\"Security and Cases disabled\"\r\nsrc=\"https://github.com/user-attachments/assets/146b8205-90f7-4218-9f1a-7b55c3bad563\">\r\n\r\n- Or in the space features config\r\n<img width=\"1213\" alt=\"Captura de pantalla 2024-09-03 a les 15 31 09\"\r\nsrc=\"https://github.com/user-attachments/assets/2563675a-d956-4422-a887-d6d95bcad773\">\r\n\r\n\r\nThis is fixed now:\r\n\r\nBefore:\r\n<img width=\"1302\" alt=\"Security app incorrectly enabled\"\r\nsrc=\"https://github.com/user-attachments/assets/8031f054-7cfb-4098-93c2-eac402501887\">\r\n\r\nAfter:\r\n<img width=\"1302\" alt=\"Security app disabled properly\"\r\nsrc=\"https://github.com/user-attachments/assets/a4f38ec2-fb78-4b1b-8c2d-bac58b97ff99\">\r\n\r\n\r\n### Caveat\r\n\r\nAs per this PR changes: https://github.com/elastic/kibana/pull/113573\r\nIn the Kibana features of the role, under the Security catalog, both\r\nSecurity and Cases features need to be `none` for the Security Solution\r\nplugin to be disabled. Otherwise, we must enable the plugin and make the\r\nenabled features available. So, with a role with the following Kibana\r\nfeatures:\r\n\r\n<img width=\"737\" alt=\"Security disabled cases enabled\"\r\nsrc=\"https://github.com/user-attachments/assets/aca8288e-9dd9-49d0-b864-e60273d30759\">\r\n\r\nThe Security app needs to be available and display only Cases available:\r\n\r\n<img width=\"247\" alt=\"navigation with only cases\"\r\nsrc=\"https://github.com/user-attachments/assets/d4866edb-1d1d-4290-a399-76a37536b05c\">\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"e373e443770399d4b0401b02abc39f794a3ec321"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/191965","number":191965,"mergeCommit":{"message":"[Security Solution] Fix the feature app list (elastic#191965)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana-team/issues/1136\r\n\r\nThe Kibana feature definition for Security Solution was missing the\r\ncorrect plugin ID registered in the `app` definition. We were still\r\ndefining the old _\"securitySolution\"_ app ID in the `app` property,\r\ninstead of the new _\"securitySolutionUI\"_ ID.\r\n\r\nThe Security Solution plugin ID change (_\"securitySolution\"_ ->\r\n_\"securitySolutionUI\"_) was done a long time ago, the inconsistency with\r\nthe Security feature definition is causing the _Security_ app to still\r\nbe visible in the global search when the Security feature is disabled:\r\n\r\n- In the role features\r\n<img width=\"737\" alt=\"Security and Cases disabled\"\r\nsrc=\"https://github.com/user-attachments/assets/146b8205-90f7-4218-9f1a-7b55c3bad563\">\r\n\r\n- Or in the space features config\r\n<img width=\"1213\" alt=\"Captura de pantalla 2024-09-03 a les 15 31 09\"\r\nsrc=\"https://github.com/user-attachments/assets/2563675a-d956-4422-a887-d6d95bcad773\">\r\n\r\n\r\nThis is fixed now:\r\n\r\nBefore:\r\n<img width=\"1302\" alt=\"Security app incorrectly enabled\"\r\nsrc=\"https://github.com/user-attachments/assets/8031f054-7cfb-4098-93c2-eac402501887\">\r\n\r\nAfter:\r\n<img width=\"1302\" alt=\"Security app disabled properly\"\r\nsrc=\"https://github.com/user-attachments/assets/a4f38ec2-fb78-4b1b-8c2d-bac58b97ff99\">\r\n\r\n\r\n### Caveat\r\n\r\nAs per this PR changes: https://github.com/elastic/kibana/pull/113573\r\nIn the Kibana features of the role, under the Security catalog, both\r\nSecurity and Cases features need to be `none` for the Security Solution\r\nplugin to be disabled. Otherwise, we must enable the plugin and make the\r\nenabled features available. So, with a role with the following Kibana\r\nfeatures:\r\n\r\n<img width=\"737\" alt=\"Security disabled cases enabled\"\r\nsrc=\"https://github.com/user-attachments/assets/aca8288e-9dd9-49d0-b864-e60273d30759\">\r\n\r\nThe Security app needs to be available and display only Cases available:\r\n\r\n<img width=\"247\" alt=\"navigation with only cases\"\r\nsrc=\"https://github.com/user-attachments/assets/d4866edb-1d1d-4290-a399-76a37536b05c\">\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"e373e443770399d4b0401b02abc39f794a3ec321"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sergi Massaneda <[email protected]>
- Loading branch information