Adding documentation for TLS registries configuration #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nephio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Catalin-Stratulat-Ericsson
requested review from
kispaljr,
nagygergo,
CsatariGergely,
liamfallon,
efiacor,
kushnaidu and
JamesMcDermott
CsatariGergely
suggested changes
Nov 13, 2024
content/en/docs/porch/using-porch/using-authenticated-private-registries.md
Outdated
Show resolved
Hide resolved
content/en/docs/porch/using-porch/using-authenticated-private-registries.md
Outdated
Show resolved
Hide resolved
content/en/docs/porch/using-porch/using-authenticated-private-registries.md
Outdated
Show resolved
Hide resolved
content/en/docs/porch/using-porch/using-authenticated-private-registries.md
Outdated
Show resolved
Hide resolved
content/en/docs/porch/using-porch/using-authenticated-private-registries.md
Outdated
Show resolved
Hide resolved
content/en/docs/porch/using-porch/using-authenticated-private-registries.md
Outdated
Show resolved
Hide resolved
content/en/docs/porch/using-porch/using-authenticated-private-registries.md
Outdated
Show resolved
Hide resolved
…registries.md Co-authored-by: Gergely Csatari <[email protected]>
…registries.md Co-authored-by: Gergely Csatari <[email protected]>
…registries.md Co-authored-by: Gergely Csatari <[email protected]>
…registries.md Co-authored-by: Gergely Csatari <[email protected]>
…registries.md Co-authored-by: Gergely Csatari <[email protected]>
…registries.md Co-authored-by: Gergely Csatari <[email protected]>
…registries.md Co-authored-by: Gergely Csatari <[email protected]>
…registries.md Co-authored-by: Gergely Csatari <[email protected]>
|
/approve |
content/en/docs/porch/using-porch/using-authenticated-private-registries.md
Outdated
Show resolved
Hide resolved
content/en/docs/porch/using-porch/using-authenticated-private-registries.md
Outdated
Show resolved
Hide resolved
content/en/docs/porch/using-porch/using-authenticated-private-registries.md
Outdated
Show resolved
Hide resolved
content/en/docs/porch/using-porch/using-authenticated-private-registries.md
Outdated
Show resolved
Hide resolved
content/en/docs/porch/using-porch/using-authenticated-private-registries.md
Outdated
Show resolved
Hide resolved
content/en/docs/porch/using-porch/using-authenticated-private-registries.md
Outdated
Show resolved
Hide resolved
content/en/docs/porch/using-porch/using-authenticated-private-registries.md
Outdated
Show resolved
Hide resolved
content/en/docs/porch/using-porch/using-authenticated-private-registries.md
Outdated
Show resolved
Hide resolved
content/en/docs/porch/using-porch/using-authenticated-private-registries.md
Outdated
Show resolved
Hide resolved
content/en/docs/porch/using-porch/using-authenticated-private-registries.md
Outdated
Show resolved
Hide resolved
content/en/docs/porch/using-porch/using-authenticated-private-registries.md
Outdated
Show resolved
Hide resolved
content/en/docs/porch/using-porch/using-authenticated-private-registries.md
Outdated
Show resolved
Hide resolved
content/en/docs/porch/using-porch/using-authenticated-private-registries.md
Outdated
Show resolved
Hide resolved
content/en/docs/porch/using-porch/using-authenticated-private-registries.md
Outdated
Show resolved
Hide resolved
content/en/docs/porch/using-porch/using-authenticated-private-registries.md
Outdated
Show resolved
Hide resolved
…registries.md Co-authored-by: JamesMcDermott <[email protected]>
…registries.md Co-authored-by: JamesMcDermott <[email protected]>
…registries.md Co-authored-by: JamesMcDermott <[email protected]>
|
/approve |
liamfallon
reviewed
Nov 19, 2024
There was a problem hiding this comment.
I think it would be better to cover each case in separate sections here, it's difficult to follow when the different configuraiton options are mixed together int he explanation.
liamfallon
reviewed
Nov 20, 2024
content/en/docs/porch/using-porch/using-authenticated-private-registries.md
Outdated
Show resolved
Hide resolved
liamfallon
reviewed
Nov 20, 2024
content/en/docs/porch/using-porch/using-authenticated-private-registries.md
Outdated
Show resolved
Hide resolved
liamfallon
reviewed
Nov 20, 2024
content/en/docs/porch/using-porch/using-authenticated-private-registries.md
Outdated
Show resolved
Hide resolved
liamfallon
reviewed
Nov 20, 2024
content/en/docs/porch/using-porch/using-authenticated-private-registries.md
Outdated
Show resolved
Hide resolved
liamfallon
reviewed
Nov 20, 2024
content/en/docs/porch/using-porch/using-authenticated-private-registries.md
Outdated
Show resolved
Hide resolved
…registries.md Co-authored-by: Liam Fallon <[email protected]>
…registries.md Co-authored-by: Liam Fallon <[email protected]>
…registries.md Co-authored-by: Liam Fallon <[email protected]>
…registries.md Co-authored-by: Liam Fallon <[email protected]>
…registries.md Co-authored-by: Liam Fallon <[email protected]>
|
Looks good Catalin. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CsatariGergely, JamesMcDermott, kushnaidu, liamfallon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paired with PR#139
adds documentation for configuring custom CA certificate integration for private TLS registries