the card component #84
Conversation
There was a problem hiding this comment.
did you also delete the old button.tsx file?
There was a problem hiding this comment.
I don't think so, i think i just renamed the old botton.tsx
| @@ -0,0 +1,58 @@ | |||
| import React, { useState } from 'react'; | |||
| import { PiSpeakerHighFill } from "react-icons/pi"; | |||
There was a problem hiding this comment.
we have fontawesome installed as a dependency - can we use an icon from there?
| import React, { useState } from 'react'; | ||
| import { PiSpeakerHighFill } from "react-icons/pi"; | ||
|
|
||
| const Card: React.FC<{ |
There was a problem hiding this comment.
you can import this in line 1 similar to how you did useState
There was a problem hiding this comment.
same with React.MouseEvent below
| TranslatedWord: string; | ||
| Pronunciation: string; | ||
| DevenagiriSpelling: string; | ||
| ImageUrl: string; |
There was a problem hiding this comment.
These types look great! A few things to account for - the ImageUrl and PronounciationUrl should be optional because not all words from the API have them available.
| @tailwind base; |
There was a problem hiding this comment.
can you make sure that lint runs on this file - the spacing looks a bit off
There was a problem hiding this comment.
I don't think the lint catches formatting issues like this, but try to get rid of the extra spaces in this file.
On a related note, there are also lint issues that you need to fix. Error that appear when you run the command pnpm run lint. You can also see the errors in github actions like so:
Fix any errors that appear for your files, you can ignore the errors that appear related to useNewari.
here's the card component,