denols: current status (meta issue)

[sigmaSd]

This issue is meant to keep track of the current status of denols, this should help us to focus on whats missing to bring denols on par with vscode-deno.

bugs:

• jumping to definition then returning breaks lsp denols: jumping to definition then returning breaks lsp #1998
• relative dependencies inside virtual text document is not resolved correctly fix(uri): don't use full path for custom schema neovim#19773
  
• codelens fails to call denolscache fix(denols): handle deno.cache from codeaction #2016
  
• DenolsCache works but it throws an error method not found denols: Ignore caching error #2009
  
• the lsp log always shows this line

[ERROR][2022-07-15 07:12:55] .../vim/lsp/rpc.lua:420	"rpc"	"deno"	"stderr"	"Error converting specifier settings (file:///home/mrcool/dev/deno/lab/deno:/https/deno.land/x/simple_shell/mod.ts): Error converting specifier settings: invalid type: null, expected struct SpecifierSettings\n"

missing features:

commands: https://deno.land/manual/language_server/overview#commands

• deno.test

requests: https://deno.land/manual/language_server/overview#requests

• deno/performance
• deno/reloadImportRegistries
• deno/task https://deno.land/manual/tools/task_runner feat(denols): add deno task #2014

notification:: https://deno.land/manual/language_server/overview#notifications

• deno/registryState feat(denols): handle registeryState notification #2027

[sigmaSd]

Regarding

relative dependencies inside virtual text document is not resolved correctly

The problem is in virtual text nvim automatically adds the current file-path to deno schema so
deno:/https/deno.land/x/simple_shell%400.13.0/mod.ts becomes /home/user/dev/deno:/https/deno.land/x/simple_shell%400.13.0/mod.ts

[sigmaSd]

Currently there is only one bug remaining neovim/neovim#19967 with that fixed the experience is equivalent to vscode-deno

The missing features can be implemented in a separate plugins once this bug is fixed.

[sigmaSd]

I wrote a plugin for this https://github.com/sigmaSd/deno-nvim

[justinmk]

@sigmaSd nice! Feel free to reference that from the docs here.

[sigmaSd]

done thanks!

I think I can close this issue now, the remaining bug have issues upstream already.

[justinmk]

FWIW, #1937 is still open because I think it makes sense to have very thin (1-2 lines per command) or auto-generated commands if there's a way for the client to "discover" LSP server capabilities and generate commands for (custom) server actions. But for non-trivial commands and features, separate plugins are appropriate.

[sigmaSd]

I see thanks for the heads up.

[mfussenegger]

if there's a way for the client to "discover" LSP server capabilities and generate commands for (custom) server actions.

Short answer: it's not possible
Long answer: although it's possible to discover what kind of commands the server supports (They're listed as part of the server_capabilities), the arguments the commands require are not described. That makes sensible auto generation of client commands pretty much impossible

[justinmk]

Thanks @mfussenegger . That leaves the "very thin" option. But that's probably not possible to do in a generic way.

[carere]

Hello, I have a problem when importing dependencies from esm.sh, Deno Intelissense in NeoVim do not work for esm.sh imported packages. It works for deno.land & npm: packages, but not for esm.sh.
I still can run my program with Deno, but the types are not loaded by denols, even so there are present in the cache folder.

[sigmaSd]

Can you provide typescript example that reproduce the issue

[carere]

Ok, the problem was coming from the fact that I did not run the deno cache before running my program.
Actually, the deno cache command downloaded all the types from esm.sh 😄