Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master #2

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Master #2

wants to merge 8 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 17, 2015

The check for gathering a list of missing jobs that need to be added
was comparing differently formatted job names, so it never found any
matches.

Minthorne, Josh and others added 8 commits September 17, 2015 09:15
The check for gathering a list of missing jobs that need to be added
was comparing differently formatted job names, so it never found any
matches.
The regex wasn’t finding all the jobs it needed to, so not enough
TemplateJob objects were being created.
Simplifying code and moving the baseName to a parameter
Using the TemplateJob and ConcreteJob objects added needless complexity
to the code. This version relies on strings of job names and branch
names.
@poznachowski
Copy link
Contributor

I can't merge your PR as in @9b41789 you have changed the way we handle feature names. If you can make that configurable that we can work with that. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant