Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Add migration for getLabel with NodeLabelGeneratorRector #89

Merged
merged 1 commit into from
Oct 18, 2024
Merged

TASK: Add migration for getLabel with NodeLabelGeneratorRector #89

merged 1 commit into from
Oct 18, 2024

Conversation

dlubitz
Copy link
Contributor

@dlubitz dlubitz commented Oct 18, 2024

Fixes: #71

@dlubitz dlubitz requested a review from mhsdesign October 18, 2024 17:25
bwaidelich
bwaidelich approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 by reading, you're the man!

mhsdesign
mhsdesign approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much <3 for all the adjustments here;)
I think i started to work on this but got side tracked^^

@dlubitz dlubitz merged commit 8c8acdd into main Oct 18, 2024
2 checks passed
@dlubitz dlubitz deleted the task/node-label-generator branch October 18, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhsdesign mhsdesign mhsdesign approved these changes

@bwaidelich bwaidelich bwaidelich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate ${node.label} to ${q(node).label()}
3 participants
@dlubitz @bwaidelich @mhsdesign