Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Remove obvious occurrences of legacy content repository class references #5428

Draft
wants to merge 1 commit into
base: 9.0
Choose a base branch
from

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Jan 7, 2025

in the documentation

I used a simple find with the following cases. Maybe such thing can also help as final step in rector to make sure we got EVERYTHING?

  • AbstractNodeData
  • ContentContext
  • ContentContextFactory
  • ContentDimensionRepository
  • ContentObjectProxy
  • ContextFactory
  • NodeAggregateIdentifier
  • NodeData
  • NodeDataRepository
  • NodeDimension
  • NodeFactory
  • NodeInterface
  • NodePropertyConversionService
  • NodePropertyConverterService
  • NodeTemplate
  • NodeTypeConstraintFactory
  • PropertyCollectionInterface
  • PublishingService
  • PublishingServiceInterface
  • TraversableNodeInterface
  • TraversableNodes
  • WorkspaceRepository

And further checked via this regex

Neos\\ContentRepository\\(Command|Configuration|Domain|Eel|Exception|Migration|NodeTypePostprocessor|Persistence|Security|Service|TypeConverter|Validation|ViewHelpers|Utility|Exception)

All other possible fully qualified class names like Neos\ContentRepository\Domain\Model\Node, Neos\ContentRepository\Domain\Model\NodeType or Neos\ContentRepository\Domain\Model\Workspace and more.

@mhsdesign mhsdesign marked this pull request as draft January 8, 2025 19:42
@mhsdesign
Copy link
Member Author

TODO:

1.) rewrite / adjust node migration documentation:

They all implement the ``Neos\ContentRepository\NodeMigration\Transformation\TransformationFactoryInterface``. Custom transformations
this class does not exist anymore.

2.) the utility used in this node migration does not exist anymore:

$dimensionsHash = Utility::sortDimensionValueArrayAndReturnDimensionsHash($dimensionsArray);
- only on Postgres with entries in the legacy event log.

@dlubitz
Copy link
Contributor

dlubitz commented Jan 9, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants