Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Improve output of PropertyCannotBeSet exception #5173

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

c4ll-m3-j4ck
Copy link
Contributor

@c4ll-m3-j4ck c4ll-m3-j4ck commented Jul 3, 2024

When a property cannot be matched on NodeCreation, an exception is thrown, but the message is not helpful because it outputs the result of get_debug_type($propertyValues) for the complete PropertyValuesToWrite object instead of the actual property. This fixes this behavior.

…n error-message

When a property cannot be matched on NodeCreation, an exception is thrown, but the message is not helpful because it outputs the result of `get_debug_type($propertyValues)` for the complete PropertyValuesToWrite object instead of the actual property. This fixes this behavior.
@github-actions github-actions bot added the 9.0 label Jul 3, 2024
Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@bwaidelich bwaidelich changed the title FIX: Output propertyValue-type instead of PropertyValueToWrite-type in error-message BUGFIX: Improve output of PropertyCannotBeSet exception Jul 4, 2024
@github-actions github-actions bot added the Bug label Jul 4, 2024
Copy link
Contributor

@grebaldi grebaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks a lot @c4ll-m3-j4ck! 👍

@grebaldi grebaldi merged commit 38cdd4c into neos:9.0 Jul 8, 2024
14 checks passed
@c4ll-m3-j4ck c4ll-m3-j4ck deleted the patch-1 branch July 8, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants