Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX Disable uriPathSegment Validation on Hompage #5172

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

wolffc
Copy link
Contributor

@wolffc wolffc commented Jul 3, 2024

Disable uriPathSegment Validation on Hompage

Followup to #4621

Upgrade instructions

nothing

Review instructions

before this change the it was not possible to save Properties of the Hompage.
And a red warning showed up:

image

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

Validation must be disabled to allow editing of the Homepage properties. or the Neos UI show a Validation error and forbid saving of data.
@github-actions github-actions bot added the 9.0 label Jul 3, 2024
Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ;)

@mhsdesign mhsdesign merged commit 501a0c1 into neos:9.0 Jul 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants