Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

!!! TASK: streamline NodeReferencesWereSet::$nodeAggregateId #5153

Merged
merged 5 commits into from
Jul 8, 2024
Merged

!!! TASK: streamline NodeReferencesWereSet::$nodeAggregateId #5153

merged 5 commits into from
Jul 8, 2024

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Jun 19, 2024 •
edited
Loading

The property was previously named $sourceNodeAggregateId which is a total anomaly to all other events.

To simplify code working with a range of events by interface (EmbedsContentStreamAndNodeAggregateId) we should align the name property. See also: #5152

Upgrade instructions

NodeReferencesWereSet::$sourceNodeAggregateId was renamed to NodeReferencesWereSet::$nodeAggregateId

Review instructions

Also adds tests for another event runtime migration that we already had but was previously untested which is not a good idea as shown by the last bug ^^ :D

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

mhsdesign added 4 commits June 19, 2024 19:34
@mhsdesign
TASK: streamline NodeReferencesWereSet::$nodeAggregateId
1ede8e5 
The property was previously named `$sourceNodeAggregateId` which is a total anomaly to all other events.

To simplify code working with a range of events by interface (`EmbedsContentStreamAndNodeAggregateId`)  we should align the name property. See also:
neos#5152
@mhsdesign
TASK: Document NodeAggregateWasMovedTest Test
a9e8fa6 
Followup to neos#5070
@mhsdesign
TASK: Better late than never, add test for legacy runtime transformat…
21d4c3b 
…ions

introduced with neos#4961
@mhsdesign
TASK: Add test for rename of `NodeReferencesWereSet::$sourceNodeAggre…
5977fe1 
…gateId`
@mhsdesign mhsdesign requested a review from kitsunet June 19, 2024 18:15
@github-actions github-actions bot added the 9.0 label Jun 19, 2024
@mhsdesign mhsdesign requested a review from nezaniel June 19, 2024 18:16
@mhsdesign mhsdesign force-pushed the task/streamlineNodeReferencesWereSet branch from ec75b3e to f127233 Compare June 19, 2024 18:54
@mhsdesign mhsdesign mentioned this pull request Jun 20, 2024
Closed
bwaidelich
bwaidelich approved these changes Jul 6, 2024
View reviewed changes
Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes a lot of sense, thanks!!

grebaldi
grebaldi approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@grebaldi grebaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mhsdesign mhsdesign merged commit 78bdd81 into neos:9.0 Jul 8, 2024
10 checks passed
@mhsdesign mhsdesign deleted the task/streamlineNodeReferencesWereSet branch July 13, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grebaldi grebaldi grebaldi approved these changes

@bwaidelich bwaidelich bwaidelich approved these changes

@kitsunet kitsunet Awaiting requested review from kitsunet

@nezaniel nezaniel Awaiting requested review from nezaniel

Assignees
No one assigned
Labels
9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhsdesign @bwaidelich @grebaldi