TASK: Remove obsolete OUTDATED_CONFLICT state leftovers

[mhsdesign]

Resolves: #5101

Upgrade instructions

Review instructions

MUST BE CAREFULLY REVIEWED... please dont trust my proposal :D

with #4965 we never create rebase was failed events anymore and the logic to query OUTDATED_CONFLICT workspaces was removed.
To have a consistent and understandable codebase without dead artefacts i removed the OUTDATED_CONFLICT flag and for the legacy event (in case of a replay) OUTDATED will be written to the database as otherwise the workspace will probably disappear and not be to recover

Checklist

• Code follows the PSR-2 coding style
• Tests have been created, run and adjusted as needed
• The PR is created against the lowest maintained branch
• Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
• Reviewer - The first section explains the change briefly for change-logs
• Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

[dlubitz]

Looks good to me by reading.

[pKallert]

Since we remove the OUTDATED_CONFLICT, perhaps the test scenario text here should be adjusted?

neos-development-collection/Neos.ContentRepository.BehavioralTests/Tests/Behavior/Features/W6-WorkspaceRebasing/03-RebasingWithConflictingChanges.feature

Line 49 in 10e3259

Scenario: Conflicting changes lead to OUTDATED_CONFLICT which can be recovered from via forced rebase

[nezaniel]

this will require a projection:replay if there are workspaces in the then removed state, right?

[mhsdesign]

Without this and outdated-conflict workspace cannot be properly be queryd i guess ... but yes if you happen to have an conflict workspace from before #4965 you might need a replay to fix the state but maybe not. In general i think with beta10 out there a long time its probably neglect able that people have a conflict workspace. This was just meant as simple code cleanup as this is dead code.

[mhsdesign]

We want to change the state calculation possibly in general so this can then be done in turn with that cc @bwaidelich

[mhsdesign]

will be fixed and refactored via #5274