Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!!! TASK: Remove Neos.Rendering helper #4861

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Jan 31, 2024

Subtask of #4478

Upgrade instructions

In case this unstable helper was used, you should look into the following alternatives or reimplement it yourself.

  • labelForNodeType
    The nodes label can be fetched via node.label.

  • renderDimensions
    And dimension related information can be fetched via the \Neos\Neos\Fusion\Helper\DimensionHelper (Neos.Dimension.*)

Review instructions

The helper was annotated with

These helpers are WORK IN PROGRESS and NOT STABLE YET

(okay since aaaages but still)
and we have no use for it ourselves and its not migrated yet. On a road to stable 9.0 we have to decide to either reimplement or remove.

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign mhsdesign changed the title TASK: Remove Neos.Rendering helper !!! TASK: Remove Neos.Rendering helper Jan 31, 2024
@ahaeslich
Copy link
Member

@mhsdesign if someone want's to reimplement this helper for oneself couldn't we at least point to the DimensionHelper to reference how to get them?

@mhsdesign mhsdesign merged commit b28c512 into neos:9.0 Feb 9, 2024
16 checks passed
@mhsdesign mhsdesign deleted the task/removeWipRenderingHelper branch February 9, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants