-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: NodeMigration with target workspace #4685
Conversation
118e534
to
9d28e6e
Compare
9d28e6e
to
8e56829
Compare
…e/nodemigration # Conflicts: # Neos.ContentRepository.NodeMigration/src/NodeMigrationService.php # Neos.ContentRepository.TestSuite/Classes/Behavior/Features/Bootstrap/MigrationsTrait.php
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i was not part of the discussions at the frankfurt sprint so im not sure i really understand will have to sync with you or try this out ^^
id favor a review from someone you discussed this with
...avioralTests/Tests/Behavior/Features/EventSourced/Migration/AddDimensionShineThrough.feature
Outdated
Show resolved
Hide resolved
Even if I'm sure you attended that discussion 😜 I'm happy to sync. Consent was actually to get it working similar to the node migration in Neos <9, because the previous version (in Neos 9) did not and keep a bit of flexibility to execute node migrations in branches for reviewing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the adjustments 💖
@nezaniel Would be great to get your approval here, to get this merged. 🙏 |
Overhaul node migrations to work with a target workspace and the ability to get the migrations immediately published after successful migration.
This was discussed on the Frankfurt Sprint. It changes the handling of node migrations back to a similar behavior as in Neos <9 and publishes changes of node migrations into the source branch immediately, but allows still to execute node migrations into reviewable workspaces.
Fixes #4442