META 9.0 cleanup todos; commented code; commented/skipped tests; check php inline docs;

[mhsdesign]

• cleanup todos. There were many todo comments added from 8.3 to 9.0. Some of those are probably already resolved and were just early thoughts but i saw here and there a few that probably need to be addressed. Either way we should reduce the todos - especially if they are outdated.

  • Discussion improve site entity and site node relation #4470
  • improve

    neos-development-collection/Neos.Neos/Classes/Controller/Frontend/NodeController.php

    Line 364 in 5e485ee

    // @todo use node aggregate identifier instead?

• cleanup dangerous assert expressions. Instead of using php docs var tag /** @var we started using phps assert. But we should make sure that we never assert anything that could possibly really fail, as for this cases we should throw a real exception.

• cleanup commented code. Some implementations are partially commented out as they havent been adjusted to work with Neos 9.0 yet and to avoid linting errors. We should make sure we know about all places and fix them or remove them.

• cleanup dead policy yaml regexes (see META 9.0 cleanup todos; commented code; commented/skipped tests; check php inline docs; #4478 (comment))

  • TASK: Remove policy for removed fluid widgets #5427
  • TASK: Remove policy for removed Neos\Neos\Service\Controller\NodeController #5424

• cleanup commented/skipped tests. We started to write tests in behat. The old Neos.Neos functional tests (also regarding fusion prototypes) should be migrated to behat. Not necessarily 1 to 1 but to cover all important features / usecases.

• cleanup unused new code

  • neos-development-collection/Neos.ContentRepository.Core/Classes/Dimension/ContentDimension.php

    Line 99 in 88cb1fd

    * @deprecated not used - shall we remove it?

  • ✅

    neos-development-collection/Neos.ContentRepository.Core/Classes/Feature/NodeAggregateCommandHandler.php

    Line 186 in a2a0447

    * @todo perhaps reuse when ChangeNodeAggregateType is reimplemented

  • (

    neos-development-collection/Neos.ContentRepository.Core/Classes/Feature/Common/ConstraintChecks.php

    Line 191 in 7edbbdc

    protected function requireNodeTypeToDeclareProperty(NodeTypeName $nodeTypeName, PropertyName $propertyName): void

    )
  • stuff inside NodeVariationInternals

• check php inline docs. References via {@see fooo} should link to existent places. I just found out that our main read model - the beloved node - had long unnoticed misleading documentation, because the docs were originally written for methods and not properties. (Maybe leverage phpstan to check @see annotations?

  • neos-development-collection/Neos.ContentRepository.Core/Classes/Projection/ContentGraph/Node.php

    Lines 44 to 52 in 71e64ed

    	/**
    	* NodeAggregateId (identifier) of this node
    	* This is part of the node's "Read Model" identity, whis is defined by:
    	* - {@see getSubgraphIdentitity}
    	* - {@see getNodeAggregateId} (this method)
    	*
    	* With the above information, you can fetch a Subgraph using {@see ContentGraphInterface::getSubgraph()}.
    	* or {@see \Neos\ContentRepositoryRegistry\ContentRepositoryRegistry::subgraphForNode()}
    	*/

• ✅ cleanup dead doc generation TASK: Remove doc generation for dead Neos\\ContentRepository\\ #4862

• ✅ cleanup dead imports TASK: Optimise php imports in Neos 9 code #4747

• ✅ everything around NodeReferenceSnapshot is marked wip and todo? So does copying nodes work if they have references?

  neos-development-collection/Neos.ContentRepository.Core/Classes/Feature/NodeDuplication/Dto/NodeReferenceSnapshot.php

  Line 21 in 0fe7b5a

  * @todo what is this?

• todos that are not marked as todo but just via ? and a newline \n like

  neos-development-collection/Neos.ContentRepository.Core/Classes/Projection/ContentGraph/VisibilityConstraints.php

  Line 20 in 3a7aa79

  * Maybe future: "Node Filter" tree or so as replacement of ReadNodePrivilege?

• check for Todo string in exception messages and enhance details or create a dedicated exception subclass.

• unify license headers Code Style: Unify php file licence headers and their position #5138

• ✅ Change workspace seems untested BUGFIX: Change workspace runs into endless while-loop #5184 (comment)

• Adjust readme of CR Core package that its NOT wip anymore and also in eventstore package description

• remove packages from the subsplit that are not 9.0 production packages or are not in the distribution anymore (postgresql & cr security)

• document that neos 9 doesnt work with postgresql -> 9.x: Postgres Content Graph #3855 (comment)

• remove legacy workspace service endpoints and similar things where node and workspace are used as doctrine entity

  • -> cleanup dead routes !!! Remove obsolete Neos service routes with Neos 9.0 #5423

[mhsdesign]

For example the code says here

https://github.com/neos/neos-development-collection/blame/9.0/Neos.ContentRepository.Core/Classes/Feature/NodeCreation/Command/CreateNodeAggregateWithNode.php#L64

"CREATE METHODS FÜR ALLE COMMANDS"

should we do this actually?

-> solved via #4489 ✅

[mhsdesign]

Whut isn this? https://github.com/neos/neos-development-collection/blob/73bf90f9348a1c560b61a8f112f8d0bc80942925/Neos.Neos/Classes/EventLog/Integrations/ContentRepositoryIntegrationService.php

-> solved via #4553 ✅

[mhsdesign]

Another good one:

neos-development-collection/Neos.Neos/Classes/Domain/Model/Site.php

Lines 158 to 159 in 53a0d13

	* If you need to fetch the root node for this site, use the content
	* context, do not use the NodeDataRepository!

ha you wish

[mhsdesign]

@pKallert noted that we match unused methods

Unneeded permissions from deprecated methods: Is there a way to do an automated check? Old permissions @Paula Kallert

-> solved via #5424 ✅

[mhsdesign]

Regarding the method privileges and aop topic. An investigation shows that following classes are part of a method() match but not part of $this->reflectionService->getAllClassNames() meaning they cannot be proxied.

The 'Imagine' things will be handled via neos/imagine#24

All others have to be tackled here or in the Neos ui.

Imagine\Image\Palette\CMYK
Imagine\Image\Palette\Grayscale
Imagine\Image\Palette\RGB
Neos\ContentRepository\ViewHelpers\Widget\Controller\PaginateController
Neos\Neos\Service\Controller\NodeController
Neos\Neos\Ui\Controller\LoginController
Neos\Neos\ViewHelpers\Widget\Controller\LinkRepositoryController

Full list

.*
Flowpack\Neos\FrontendLogin\Controller\AuthenticationController
Flowpack\Neos\Matomo\Controller\Module\MatomoController
Imagine\Image\Palette\CMYK
Imagine\Image\Palette\Grayscale
Imagine\Image\Palette\RGB
Neos\ContentRepository\ViewHelpers\Widget\Controller\PaginateController
Neos\Flow\I18n\Translator
Neos\Flow\Persistence\AbstractPersistenceManager
Neos\Flow\Security\Authentication\Controller\AbstractAuthenticationController
Neos\Flow\Security\Authorization\PrivilegeManager
Neos\Flow\Security\Authorization\Privilege\Method\MethodPrivilege
Neos\FluidAdaptor\ViewHelpers\Widget\Controller\AutocompleteController
Neos\FluidAdaptor\ViewHelpers\Widget\Controller\PaginateController
Neos\Fusion\View\FusionView
Neos\Media\Browser\Controller\(Asset|Image)Controller
Neos\Media\Browser\Controller\AssetCollectionController
Neos\Media\Browser\Controller\AssetProxyController
Neos\Media\Browser\Controller\ImageVariantController
Neos\Media\Browser\Controller\TagController
Neos\Media\Browser\Controller\UsageController
Neos\Media\Browser\ViewHelpers\Controller\(Paginate)Controller
Neos\Media\Controller\ThumbnailController
Neos\Neos\Controller\Backend\BackendController
Neos\Neos\Controller\Backend\ContentController
Neos\Neos\Controller\Backend\ImpersonateController
Neos\Neos\Controller\Backend\ModuleController
Neos\Neos\Controller\Backend\SchemaController
Neos\Neos\Controller\Backend\SettingsController
Neos\Neos\Controller\Frontend\NodeController
Neos\Neos\Controller\LoginController
Neos\Neos\Controller\Module\AbstractModuleController
Neos\Neos\Controller\Module\AdministrationController
Neos\Neos\Controller\Module\Administration\ConfigurationController
Neos\Neos\Controller\Module\Administration\DimensionController
Neos\Neos\Controller\Module\Administration\PackagesController
Neos\Neos\Controller\Module\Administration\SitesController
Neos\Neos\Controller\Module\Administration\UsersController
Neos\Neos\Controller\Module\ManagementController
Neos\Neos\Controller\Module\UserController
Neos\Neos\Controller\Module\User\UserSettingsController
Neos\Neos\Controller\Service\AssetProxiesController
Neos\Neos\Controller\Service\AssetsController
Neos\Neos\Controller\Service\ContentDimensionsController
Neos\Neos\Controller\Service\NodesController
Neos\Neos\Domain\Repository\DomainRepository
Neos\Neos\Domain\Repository\SiteRepository
Neos\Neos\Service\Controller\AbstractServiceController
Neos\Neos\Service\Controller\DataSourceController
Neos\Neos\Service\Controller\NodeController
Neos\Neos\Service\Controller\UserPreferenceController
Neos\Neos\Ui\Controller\BackendController
Neos\Neos\Ui\Controller\BackendServiceController
Neos\Neos\Ui\Controller\LoginController
Neos\Neos\ViewHelpers\Widget\Controller\LinkRepositoryController
Neos\RedirectHandler\Ui\Controller\ModuleController
Neos\Setup\Controller\RuntimeHealthController
Neos\TestNodeTypes\Application\.*\Controller\.*Controller
Neos\Workspace\Ui\Controller\WorkspaceController

all other designators dont seem to use outdated expressions

classAnnotatedWith
class
methodAnnotatedWith
within
filter
setting

and we actually get rid of ALL usages of evaluate() with Neos 9 !!!