-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ndev 3414 update solana to v2.0 #579
base: develop
Are you sure you want to change the base?
Conversation
1062296
to
20d7f04
Compare
20d7f04
to
5b82c28
Compare
Dapps report |
Solana Requests Statistics
|
cargo build --release && \ | ||
cargo clippy --release \ | ||
--config 'patch.crates-io.ethnum.git="https://github.com/neonlabsorg/ethnum.git"'\ | ||
--config 'patch.crates-io.ethnum.branch="NDEV-3414-u256-in-u64-4-implementation"' && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create PR into neonlabsorg/ethnum.git
to merge branch into main
thiserror = "1.0" | ||
arrayref = "0.3.8" | ||
hex = "0.4.3" | ||
ripemd = "0.1" | ||
rlp = "0.5" | ||
static_assertions = "1" | ||
borsh = "0.10" | ||
borsh = "1.5.2" | ||
borsh010 = { version = "0.10.4", package = "borsh" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the difference between borsch v1.5.2 and v0.10.4? Why do we need to use both of them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no difference for us between this two crates. Mpl-token-metadata crate depends on >=0.9, <1.0 borsh. Solana-program depends on both borsh 1.5 and 0.10. So, we need to tell which version of borsh. Because it does not support deserialization from v1.5 trait.
No description provided.