ci: use reusable workflow for MacOs build #9392
Conversation
fedordikarev
added
the
run-extra-build-macos
.github/workflows/build-macos.yml
Outdated
| - name: Check for Postgres changes | ||
| uses: dorny/paths-filter@1441771bbfdd59dcd748680ee64ebd8faab1a242 #v3 | ||
| id: postgres_changes | ||
| with: | ||
| token: ${{ github.token }} | ||
| filters: | | ||
| postgres-v14: ['vendor/postgres-v14/**', 'Makefile', '.github/workflows/build-macos.yml', 'pgxn/**'] | ||
| postgres-v15: ['vendor/postgres-v15/**', 'Makefile', '.github/workflows/build-macos.yml', 'pgxn/**'] | ||
| postgres-v16: ['vendor/postgres-v16/**', 'Makefile', '.github/workflows/build-macos.yml', 'pgxn/**'] | ||
| postgres-v17: ['vendor/postgres-v17/**', 'Makefile', '.github/workflows/build-macos.yml', 'pgxn/**'] | ||
| base: ${{ github.event_name != 'pull_request' && (github.event.merge_group.base_ref || github.ref_name) || '' }} | ||
| ref: ${{ github.event_name != 'pull_request' && (github.event.merge_group.head_ref || github.ref) || ''}} |
There was a problem hiding this comment.
I was thinking about having this part in the main build_and_test workflow and trigger build-macos only if there're related changes.
We might want to consider using https://github.com/tj-actions/changed-files (instead of dorny/paths-filter), I found its API nicer
| postgres_changes: ${{ steps.postgres_changes.outputs.changes }} | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@6ccd57f4c5d15bdc2fef309bd9fb6cc9db2ef1c6 # v4.1.7 |
There was a problem hiding this comment.
We're ok to use the latest tag (like @v4) for "official" actions from actions org
.github/workflows/build-macos.yml
Outdated
| contains(github.event.pull_request.labels.*.name, 'run-extra-build-*') || | ||
| github.ref_name == 'main' | ||
| timeout-minutes: 30 | ||
| runs-on: macos-14 |
There was a problem hiding this comment.
I've find out, that macos-15 is available, let's switch it?
There was a problem hiding this comment.
sounds good, done
There was a problem hiding this comment.
seems something has changed in Github runners, as build started to fail on both macos-14 and macos-15 due to ICU library not found.
and there are other complain on that library missing from the image: actions/runner-images#10989
I will anyway get back to macos-15, just to keep track of why build fails now :)
Do not merge, for dev and testing purposes
Problem
Summary of changes
Checklist before requesting a review
Checklist before merging