Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually prevent registering IModEvent handlers to the NeoForge bus #377

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Actually prevent registering IModEvent handlers to the NeoForge bus #377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/net/neoforged/neoforge/common/NeoForge.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public class NeoForge {
* Also known as the "game" bus.
*/
public static final IEventBus EVENT_BUS = BusBuilder.builder().startShutdown().classChecker(eventType -> {
if (eventType.isAssignableFrom(IModBusEvent.class)) {
if (IModBusEvent.class.isAssignableFrom(eventType)) {
throw new IllegalArgumentException("IModBusEvent events are not allowed on the common NeoForge bus! Use a mod bus instead.");
}
}).build();
Expand Down
2 changes: 1 addition & 1 deletion tests/src/main/java/net/neoforged/neoforge/oldtest/block/SlipperinessTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
import net.neoforged.neoforge.registries.RegisterEvent;

@Mod(SlipperinessTest.MOD_ID)
@EventBusSubscriber
@EventBusSubscriber(bus = EventBusSubscriber.Bus.MOD)
public class SlipperinessTest {
static final String MOD_ID = "slipperiness_test";
static final String BLOCK_ID = "test_block";
Expand Down
Loading