Implement fluid handler support for cauldrons #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pupnewfster
requested changes
Dec 11, 2023
patches/net/minecraft/world/level/block/AbstractCauldronBlock.java.patch
Show resolved
Hide resolved
patches/net/minecraft/world/level/block/AbstractCauldronBlock.java.patch
Show resolved
Hide resolved
patches/net/minecraft/world/level/block/AbstractCauldronBlock.java.patch
Show resolved
Hide resolved
src/main/java/net/neoforged/neoforge/fluids/CauldronFluidContent.java
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/neoforge/fluids/capability/wrappers/CauldronWrapper.java
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/neoforge/fluids/capability/wrappers/CauldronWrapper.java
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/neoforge/fluids/capability/wrappers/CauldronWrapper.java
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/neoforge/fluids/capability/wrappers/CauldronWrapper.java
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/neoforge/fluids/capability/wrappers/CauldronWrapper.java
Outdated
Show resolved
Hide resolved
pupnewfster
previously requested changes
Dec 11, 2023
src/main/java/net/neoforged/neoforge/fluids/capability/wrappers/CauldronWrapper.java
Outdated
Show resolved
Hide resolved
|
How does this handle the 999/1000 discrepancy? If it lets you insert 333mb to increase a level, there's a potential exploit where you insert 333mb 3 times, then extract 1000mb to create an additional millibucket. Not particularly valuable in regular gameplay, but if you're in the Nether, have finite water enabled, etc it could be exploitable. Moreso if anyone adds a cauldron block for other fluids. |
|
You can only insert 1000 at once. |
pupnewfster
added
enhancement
Matyrobbrt
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cauldrons need to be registered to
RegisterCauldronFluidContentEventif they want to be part of this system.