Partial gamerule support for FluidType#canConvertToSource of vanilla fluids #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pupnewfster
force-pushed
the
convert_check
branch
from
43617b2
to
c765279
Compare
sciwhiz12
added
enhancement
sciwhiz12
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
Looks fine to me.
Out of curiosity though, @ChampionAsh5357, do you remember why FluidType#canConvertToSource uses a LevelReader even though its two callers, IFluidExtension#canConvertToSource and BaseFlowingFluid#canConvertToSource both have Levels?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
ForgeFlowingFluidactually queries theFluidType#canConvertToSourceand the two vanilla fluids fallback to calling theFlowingFluid#canConvertToSource(Level)LevelReaderthat is not aLevelor for theFluidStackvariant ofcanConvertToSourceas in both of those cases we don't have access to gamerules so we just fallback to the default values of those gamerules (true for water and false for lava)