Inject interfaces to vanilla classes using JST

[Matyrobbrt]

This PR replaces patches with the purpose of adding interfaces to vanilla classes with a JST step. This removes another annoyance when porting as there will not be rejects caused by changes to the vanilla interfaces of classes.

To not affect userdev, we're now generating a second set of patches that will be published and that are based on the vanilla sources without interfaces, unlike the in-repo patches which are based on interface-injected sources.

[neoforged-pr-publishing]

• Publish PR to GitHub Packages

Last commit published: d9954e16f76bec28facdabb939d6b316d60c83f7.

PR Publishing

The artifacts published by this PR:

• 📦 net.neoforged:neoforge:21.4.42-beta-pr-1765-jst-interface-injection
• 📦 net.neoforged:testframework:21.4.42-beta-pr-1765-jst-interface-injection

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1765' // https://github.com/neoforged/NeoForge/pull/1765
        url 'https://prmaven.neoforged.net/NeoForge/pr1765'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1765.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1765
cd NeoForge-pr1765
curl -L https://prmaven.neoforged.net/NeoForge/pr1765/net/neoforged/neoforge/21.4.42-beta-pr-1765-jst-interface-injection/mdk-pr1765.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

[neoforged-automation]

@Matyrobbrt, this pull request has conflicts, please resolve them for this PR to move forward.

[marchermans]

How much has this been tested on the individual downstream platforms?

[Matyrobbrt]

As much as the game launching (which also verifies that recomp is successful, therefore proving the patches are correct as otherwise there would be compilation errors due to missing interfaces and methods). This PR has little to no effect in userdev as the second set of patches hides the use of interface injection from any toolchain.

[marchermans]

As much as the game launching (which also verifies that recomp is successful, therefore proving the patches are correct as otherwise there would be compilation errors due to missing interfaces and methods). This PR has little to no effect in userdev as the second set of patches hides the use of interface injection from any toolchain.

So in userdev this uses Patches? Instead of II?

[Technici4n]

Yes exactly. See the generateProductionSourcePatches task.

[marchermans]

Yes exactly. See the generateProductionSourcePatches task.

IMHO that is a lucky break, but not a great solution........ regardless, carry on, my curiosity has been satistied

[Technici4n]

Looks good! Final request: can you sort the injected interfaces file in a sensible way?

[Matyrobbrt]

Done. I sorted them alphabetically, splitting enum extensions from the others

[neoforged-releases]

🚀 This PR has been released as NeoForge version 21.4.27-beta.