-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added PlayerEvent.ItemSmithingEvent
#1693
base: 1.21.x
Are you sure you want to change the base?
Conversation
|
Executed ``` Run gradlew genPatches to generate patch-files from the patched sources Run gradlew applyAllFormatting to automatically format sources Check correct formatting with gradlew spotlessCheck ```
For when anyone reads this PR I followed the steps in CONTRIBUTING.md But when i execute
It Modifies more files then what i intend with my PR and it breaks? |
In your case, you likely:
What you're seeing is the result of having your source files (which the patch files are based off) not being in sync with your patch files. Whenever you update your local repository's main branch ( |
To fix the issue, you can either:
|
Thank you for explaining! I will resolve this issue as soon as possible. |
* Resolved the issue
I have resolved the issue using:
Thank you very much for helping me so quickly. |
This PR allows users to create an event solely related to the Smithing Table, This will allow developers to retrieve information like the Template used, the main item and the addition.
Currently there is no event that triggers when a user crafts something using the smithing table.
With this PR we will have that event which will allow developers to have more freedom when developing features around the Smithing Table.
Adds #1569.