Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21.3] Remove hardcoded ShieldItem check in LivingEntity #1676

Merged
merged 2 commits into from
Nov 10, 2024

Conversation

thomasglasser
Copy link
Contributor

This PR fixes items with the shield blocking ability not being able to block if they aren't a ShieldItem due to a hardcoded check added in 1.21.3. getItemBlockingWith is patched already so no other changes are required.

@neoforged-pr-publishing
Copy link

  • Publish PR to GitHub Packages

@thomasglasser thomasglasser changed the title Removed hardcoded ShieldItem check in LivingEntity Remove hardcoded ShieldItem check in LivingEntity Nov 9, 2024
@sciwhiz12 sciwhiz12 added bug A bug or error 1.21.3 Targeted at Minecraft 1.21.3 labels Nov 9, 2024
@thomasglasser thomasglasser changed the title Remove hardcoded ShieldItem check in LivingEntity [1.21.3] Remove hardcoded ShieldItem check in LivingEntity Nov 9, 2024
@Matyrobbrt Matyrobbrt merged commit 20ce6df into neoforged:1.21.x Nov 10, 2024
6 checks passed
@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.3.17-beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.3 Targeted at Minecraft 1.21.3 bug A bug or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants