Use CommonHooks.getCraftingRemainder #1585

[ewoudje]

CommonHooks.getCraftingRemainder doesn't get used, and 'destroyed' items were not being destroyed.

I split it over 2 commits, one fixing the actual bug, and the other one making all patches call CommonHooks instead.
I wasn't sure how it would be preferred.

Fixes #1585

[CLAassistant]

All committers have signed the CLA.

[neoforged-pr-publishing]

• Publish PR to GitHub Packages

[Shadows-of-Fire]

The patch changes in this PR are unnecessary, you've updated ItemStack#getCraftingRemainder to use the hook method, but then patched all the call sites to the hook method anyway. Undo the patch changes.

[Shadows-of-Fire]

Actually, based on further review (and looking at the levels of indirection here), the CommonHooks method should just be removed and flattened into the ItemStack method entirely.

[neoforged-compatibility-checks]

@ewoudje, this PR introduces breaking changes.
Fortunately, this project is currently accepting breaking changes, but if they are not intentional, please revert them.
Last checked commit: 95dd711ebc9d514e00c540393885a2279cb1e8d3.

neoforge (:neoforge)

• net/neoforged/neoforge/common/CommonHooks
  • getCraftingRemainder(Lnet/minecraft/world/item/ItemStack;)Lnet/minecraft/world/item/ItemStack;: ❗ API method was removed

[embeddedt]

Something feels weird about a method named getCraftingRemainder having side effects like firing a destroy item event.

[Shadows-of-Fire]

A little bit, yes; it's not entirely different than how we handle other itemstack extension methods, since the class is final. There is one call site where we don't want the event to be fired, in DataComponentIngredient#display, so I guess we need to take a different approach here. Prior to the SlotDisplay stuff the only call sites for these methods were in recipe remainder calculation.

[ewoudje]

Something feels weird about a method named getCraftingRemainder having side effects like firing a destroy item event.

I could rename it to computeCraftingRemainder or something alike? makes it more clear that it doesn't just get something.