Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unnecessary Fluid Patch Preventing Lava Movement #1661

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

ChampionAsh5357
Copy link
Contributor

Closes #1634

For some reason, there was a patch that inverted the lava check. It doesn't do anything different than just using isInLava, so the patch was removed.

@ChampionAsh5357 ChampionAsh5357 added bug A bug or error regression Worked previously but doesn't anymore 1.21.3 Targeted at Minecraft 1.21.3 labels Nov 2, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Nov 2, 2024

  • Publish PR to GitHub Packages

Last commit published: d2041dd7144c95476dfc2c1d085c289f30135ee7.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1661' // https://github.com/neoforged/NeoForge/pull/1661
        url 'https://prmaven.neoforged.net/NeoForge/pr1661'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1661.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1661
cd NeoForge-pr1661
curl -L https://prmaven.neoforged.net/NeoForge/pr1661/net/neoforged/neoforge/21.3.11-beta-pr-1661-fix-intangible-lava/mdk-pr1661.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

Copy link
Member

@sciwhiz12 sciwhiz12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

@sciwhiz12 sciwhiz12 merged commit aa45d10 into neoforged:1.21.x Nov 2, 2024
7 checks passed
@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.3.10-beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.3 Targeted at Minecraft 1.21.3 bug A bug or error regression Worked previously but doesn't anymore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(1.21.3) Lava is "intangible"
2 participants