Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21.1] Make Neoforge's Needs Netherite Tool block tag be added to vanilla's incorrect block tags #1658

Merged

Conversation

TelepathicGrunt
Copy link
Contributor

Added Javadoc to all the neoforge needs block tags to make it clear what they are for. And makes it so that Needs Netherite actually cause the block to not be mineable by diamond or below

closes #1571

1.21.3 PR: #1572

@TelepathicGrunt TelepathicGrunt added enhancement New (or improvement to existing) feature or request 1.21.1 Targeted at Minecraft 1.21.1 labels Nov 2, 2024
@TelepathicGrunt TelepathicGrunt self-assigned this Nov 2, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Nov 2, 2024

  • Publish PR to GitHub Packages

Last commit published: e213ab9bf347692809761d34753fe580fe9e8cf4.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1658' // https://github.com/neoforged/NeoForge/pull/1658
        url 'https://prmaven.neoforged.net/NeoForge/pr1658'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1658.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1658
cd NeoForge-pr1658
curl -L https://prmaven.neoforged.net/NeoForge/pr1658/net/neoforged/neoforge/21.1.81-pr-1658-NetheriteTagBackport/mdk-pr1658.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@Shadows-of-Fire Shadows-of-Fire added the backport Backport to an older version from a newer version label Nov 8, 2024
@TelepathicGrunt TelepathicGrunt merged commit b296685 into neoforged:1.21.1 Nov 11, 2024
6 checks passed
@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.1.77.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.1 Targeted at Minecraft 1.21.1 backport Backport to an older version from a newer version enhancement New (or improvement to existing) feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants