[1.21.3] Fix for data map serialization

[dhyces]

Closes #1644

Reason for this change is that RegistryOps.create wraps HolderLookup.Providers in a HolderLookupAdapter, which creates a new RegistryInfoLookup and sets the owner field to the registry itself (same object instance as the getter field), rather than whatever it was during datagen, thereby creating a disconnect between holders (which are bound to the real owner) and the registry lookup (which is now the wrong owner). However, RegistrySetBuilder uses its own anonymous HolderLookup.Provider which overrides createSerializationContext to return a RegistryOps with a RegistryInfoLookup which would obtain the correct owner for the given registry based on how it was built during RegistrySetBuilder#buildProviderWithContext.

[neoforged-pr-publishing]

• Publish PR to GitHub Packages

Last commit published: 5351fcd7616eae4b36f2bce36c04a05459d31746.

PR Publishing

The artifacts published by this PR:

• 📦 net.neoforged:neoforge:21.3.8-beta-pr-1648-fix-datamap-serialization
• 📦 net.neoforged:testframework:21.3.8-beta-pr-1648-fix-datamap-serialization

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1648' // https://github.com/neoforged/NeoForge/pull/1648
        url 'https://prmaven.neoforged.net/NeoForge/pr1648'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1648.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1648
cd NeoForge-pr1648
curl -L https://prmaven.neoforged.net/NeoForge/pr1648/net/neoforged/neoforge/21.3.8-beta-pr-1648-fix-datamap-serialization/mdk-pr1648.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

[ZestyBlaze]

Closes #1644

[neoforged-releases]

🚀 This PR has been released as NeoForge version 21.3.6-beta.