-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.21.4] Sync remaining c
tags from Fabric side
#1628
base: 1.21.x
Are you sure you want to change the base?
[1.21.4] Sync remaining c
tags from Fabric side
#1628
Conversation
c
tags from Fabric side
Last commit published: 3fea4f1f63ed68f5b122218692ef3fec20f94df6. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #1628' // https://github.com/neoforged/NeoForge/pull/1628
url 'https://prmaven.neoforged.net/NeoForge/pr1628'
content {
includeModule('net.neoforged', 'neoforge')
includeModule('net.neoforged', 'testframework')
}
}
} MDK installationIn order to setup a MDK using the latest PR version, run the following commands in a terminal. mkdir NeoForge-pr1628
cd NeoForge-pr1628
curl -L https://prmaven.neoforged.net/NeoForge/pr1628/net/neoforged/neoforge/21.4.59-beta-pr-1628-SyncToFabricTags2/mdk-pr1628.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip To test a production environment, you can download the installer from here. |
c
tags from Fabric sidec
tags from Fabric side
@TelepathicGrunt, this pull request has conflicts, please resolve them for this PR to move forward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Noticed that the Fabric PR used a different translation for "tag.block.c.fences.nether_brick". Neo's is currently "Fences Nether Brick" and the Fabric PR (as well as Neo's item tag) uses "Nether Brick Fences".
- Fabric PR uses singular "Plateau" while Neo is using plural "Plateaus" for "tag.worldgen.biome.c.is_plateau"
Neoforge 1.21.1 port: #1593
Fabric 1.21.4 PR: FabricMC/fabric#4186
Note, I did not add any new Pale Garden stuff myself to the tags because those will need special handling to only add to the tags when the user activates the feature flag. Maybe that is better split into a separate PR by someone with more experience with feature flags than me.
Fabric had some tags that was not in Neo. This PR aims to solve that by importing those tags. Specifically
c:potions
item tag andc:is_temperate
biome tags. I added the torchflower seeds toc:seeds/torchflower
and then added that to thec:seeds
tag as well as it was a missing seed.I also improved javadoc for several tags, did some cleanup in a few spots, and marked the
c:is_modified
biome tag as deprecated and for removal in 1.22. Reason being the modified tag was based off of how the old biome layout used to work in the long past. Since Mojang revamped how biomes work, this tag lost all of its meaning and serves no purpose anymore. Hence time to retire it.The PR to add the tags that are not in Fabric from Neoforge is in this other PR. Discussions ongoing of course: FabricMC/fabric#4186
The Nether stem and hyphae was missing from the Stripped wood/logs tag. This is fixed as well.