[1.21.3] Relax extensible enum coherence checks for extensible enums without custom entries

[XFactHD]

This PR relaxes the coherence checks on extensible enums to allow a client/server with an extensible enum without additional entries to connect to a server/client with the respective enum not made extensible. This ensures that a NeoForge version which makes a new enum extensible is network-compatible with the previous NeoForge version as long as no mod adds additional entries to the affected enum. With the current implementation, any additional enum being made extensible and marked as @NetworkedEnum would break network compatibility with the previous version, regardless of any mod actually making use of the extensibility.

This PR is the 1.21.3 port of #1559.

[neoforged-pr-publishing]

• Publish PR to GitHub Packages

Last commit published: c8b24b8515c233b1241a087d82905fb7a27e9c32.

PR Publishing

The artifacts published by this PR:

• 📦 net.neoforged:neoforge:21.3.2-beta-pr-1622-relax_enum_checks_21.3
• 📦 net.neoforged:testframework:21.3.2-beta-pr-1622-relax_enum_checks_21.3

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1622' // https://github.com/neoforged/NeoForge/pull/1622
        url 'https://prmaven.neoforged.net/NeoForge/pr1622'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1622.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1622
cd NeoForge-pr1622
curl -L https://prmaven.neoforged.net/NeoForge/pr1622/net/neoforged/neoforge/21.3.2-beta-pr-1622-relax_enum_checks_21.3/mdk-pr1622.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

[neoforged-releases]

🚀 This PR has been released as NeoForge version 21.3.16-beta.