-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.21.3] Allow mods to add custom FeatureFlags #1619
[1.21.3] Allow mods to add custom FeatureFlags #1619
Conversation
Last commit published: 49d3b0aa7dce9cb08bf3eaf8ac8b3478191697a1. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #1619' // https://github.com/neoforged/NeoForge/pull/1619
url 'https://prmaven.neoforged.net/NeoForge/pr1619'
content {
includeModule('net.neoforged', 'testframework')
includeModule('net.neoforged', 'neoforge')
}
}
} MDK installationIn order to setup a MDK using the latest PR version, run the following commands in a terminal. mkdir NeoForge-pr1619
cd NeoForge-pr1619
curl -L https://prmaven.neoforged.net/NeoForge/pr1619/net/neoforged/neoforge/21.3.2-beta-pr-1619-modded_feature_flags_21.3/mdk-pr1619.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip To test a production environment, you can download the installer from here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update IMenuTypeExtension.create
to allow modders to flag their MenuType
s if desired.
Reposted from Discord
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested MenuType
change was deemed not necessary, modders can simply invoke MenuType#new
and pass in the desired FeatureFlagSet
🚀 This PR has been released as NeoForge version |
This PR makes it possible for mods to add custom
FeatureFlag
s to the vanilla feature flag system. Since theFeatureFlagRegistry
holding the flags is set in stone long before mods start loading, the flags are specified in a JSON file instead of being collected by an event or similar system. To allow adding more than the 64 flags allowed by vanilla (a limitation that is not unlikely to be hit with 100s of mods in a pack), the flag masks are extended by along[]
in theFeatureFlagSet
and an offset field inFeatureFlag
for indexing into the array.Closes #1106.
This PR is the 1.21.3 port of #1538.