[1.21.2] Make block outline passes respect render types specified by the model #1600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XFactHD
added
rendering
|
Technici4n
force-pushed
the
port/1.21.2
branch
from
69ed39b to
e18c200
Compare
|
@XFactHD, this pull request has conflicts, please resolve them for this PR to move forward. |
embeddedt
reviewed
Oct 18, 2024
XFactHD
force-pushed
the
block_outline_phases
branch
from
a33ba40 to
212f9bb
Compare
embeddedt
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes block outline rendering respect the render types specified by
BakedModels when determining whether the outlines should be drawn before or after translucent geometry