-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch out spotless for an alternative #1530
Open
lukebemish
wants to merge
16
commits into
neoforged:1.21.x
Choose a base branch
from
lukebemish:no-more-spotless
base: 1.21.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+23
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ably) by new eclipse version
…can be bumped later if folks want
|
sciwhiz12
added
enhancement
New (or improvement to existing) feature or request
ci/build
Related to continuous integration/build system
1.21.1
Targeted at Minecraft 1.21.1
labels
Sep 9, 2024
sciwhiz12
reviewed
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Untested yet, but looks clean enough. I have a few spots that need some explanation, though.
Fixed to be unnecessary by new NG versions
@lukebemish, this pull request has conflicts, please resolve them for this PR to move forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
1.21.1
Targeted at Minecraft 1.21.1
ci/build
Related to continuous integration/build system
enhancement
New (or improvement to existing) feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotless has... some quirks. Among others:
immaculate
is a spotless alternative built with a much narrower scope (namely, the sort of formatting you tend to see in java projects like this), designed to utilize built-in gradle features when possible (up-to-date checking and incremental tasks for figuring out which files to re-check), prefer lazy configuration, and respect gradle best practices whereever I have any clue what they are; this PR switches neo-dev to use it instead of spotless. Note that, due to using the same version of eclipse JDT and the same other formatting steps besides that, no formatting has shifted compared to using spotless.immaculate
is new and thus rather untested;spotless
is a much more established plugin, but also has a much more established set of issues, some of which seem to be continually popping up in discord (the notable one here is the whole bit where tons of stuff is dependent on the java version used to invoke gradle). Furthermore, this change could probably use some more extensive testing to make sure it behaves right in a number of different development environments.In any case, this PR could use testing on different environments to make sure it's all behaving sensibly across dev environments.